Skip to content

Remove SystemSetNode #20100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2025
Merged

Remove SystemSetNode #20100

merged 2 commits into from
Jul 13, 2025
+8 −32

Conversation

ItsDoot
Copy link
Contributor

@ItsDoot ItsDoot commented Jul 12, 2025 •
edited
Loading

Objective

SystemSetNode doesn't really add much value beyond a couple helper functions for getting the name as a string and checking if its a SystemTypeSet. We can replace it entirely and use InternedSystemSet directly by inlining these helper functions' usages without sacrificing readability.

Solution

Remove it and replace it with direct InternedSystemSet usage.

Testing

Reusing current tests.

@ItsDoot ItsDoot added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 12, 2025
@tim-blackbird tim-blackbird added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 12, 2025
Trashtalk217
Trashtalk217 approved these changes Jul 12, 2025 •
edited
Loading
View reviewed changes
chescock
chescock approved these changes Jul 12, 2025
View reviewed changes
@ItsDoot ItsDoot changed the title Remove SystemSetNode, replace it with inherent helper functions Remove SystemSetNode Jul 12, 2025
@ItsDoot ItsDoot requested a review from alice-i-cecile July 12, 2025 19:56
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 13, 2025
Merged via the queue into bevyengine:main with commit 7ae8b53 Jul 13, 2025
32 checks passed
@ItsDoot ItsDoot mentioned this pull request Jul 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chescock chescock chescock approved these changes

@Trashtalk217 Trashtalk217 Trashtalk217 approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@alice-i-cecile alice-i-cecile Awaiting requested review from alice-i-cecile

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ItsDoot @chescock @Trashtalk217 @tim-blackbird @alice-i-cecile