-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Change event
to event_key
where it refers to an EventKey
#20060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
And now I remember that backtick has a special meaning in zsh, and my commit message doesn't make sense. 🤦♂️ |
You can still change your commit message and force-push to your PR branch. |
@copygirl thanks! |
…ually dealing with event keys
Thanks for the reviews @Zeophlite and @mockersf |
Objective
The ECS code to do with Observers was recently refactored to use an
EventKey
newtype. On reading through the PR, I was a bit confused that sometimes a variable calledevent
refers to anEvent
and sometimes it refers to anEventKey
. I think the code is clearer whenevent
refers to anEvent
andevent_key
refers to anEventKey
.Solution
This PR renames some uses of
event
toevent_key
.Testing
I ran
cargo run -p ci -- tests
No
No.
Probably not relevant, but MacOS.