Fix specular cutoff on lights with radius overlapping with mesh#19157
Merged
superdump merged 2 commits intobevyengine:mainfrom May 12, 2025
Merged
Fix specular cutoff on lights with radius overlapping with mesh#19157superdump merged 2 commits intobevyengine:mainfrom
superdump merged 2 commits intobevyengine:mainfrom
Conversation
superdump
approved these changes
May 10, 2025
mate-h
approved these changes
May 10, 2025
atlv24
added
C-Bug
superdump
approved these changes
May 12, 2025
mockersf
pushed a commit
that referenced
this pull request
May 30, 2025
# Objective - Fixes #13318 ## Solution - Clamp a dot product to be positive to avoid choosing a `centerToRay` which is not on the ray but behind it. ## Testing - Repro in #13318 Main: <img width="963" alt="{DA2A2B99-27C7-4A76-83B6-CCB70FB57CAD}" src="https://github.com/user-attachments/assets/afae8001-48ee-4762-9522-e247bbe3577a" /> This PR: <img width="963" alt="{2C4BC3E7-C6A6-4736-A916-0366FBB618DA}" src="https://github.com/user-attachments/assets/5bea4162-0b58-4df0-bf22-09fcb27dc167" /> Eevee reference: 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
centerToRaywhich is not on the ray but behind it.Testing
Main:
This PR:
Eevee reference:
