Expand the RelationshipSourceCollection
to return more information
#18241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
While redoing #18058 I needed
RelationshipSourceCollection
(henceforth referred to as the Trait) to implementclear
so I added it.Solution
Add the
clear
method to the Trait.Also make
add
andremove
report if they succeeded.Testing
Eyeballs
Showcase
The
RelationshipSourceCollection
trait now reports if adding or removing an entity from it was successful.It also not contains the
clear
method so you can easily clear the collection in generic contexts.Changes
EDITED by Alice: We should get this into 0.16, so no migration guide needed.
The
RelationshipSourceCollection
methodsadd
andremove
now need to return a boolean indicating if they were successful (adding a entity to a set that already contains it counts as failure). Additionally theclear
method has been added to support clearing the collection in generic contexts.