Expand the RelationshipSourceCollection to return more information#18241
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Mar 10, 2025
Merged
Conversation
Contributor
Author
|
I've also considered adding the |
Brezak
force-pushed
the
relationship-collection-bools
branch
from
784005c to
0dede8e
Compare
alice-i-cecile
approved these changes
Mar 10, 2025
alice-i-cecile
added
A-ECS
dmyyy
approved these changes
Mar 10, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
While redoing #18058 I needed
RelationshipSourceCollection(henceforth referred to as the Trait) to implementclearso I added it.Solution
Add the
clearmethod to the Trait.Also make
addandremovereport if they succeeded.Testing
Eyeballs
Showcase
The
RelationshipSourceCollectiontrait now reports if adding or removing an entity from it was successful.It also not contains the
clearmethod so you can easily clear the collection in generic contexts.Changes
EDITED by Alice: We should get this into 0.16, so no migration guide needed.
The
RelationshipSourceCollectionmethodsaddandremovenow need to return a boolean indicating if they were successful (adding a entity to a set that already contains it counts as failure). Additionally theclearmethod has been added to support clearing the collection in generic contexts.