Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip camera look ups in queue uinodes #17668

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Skip camera look ups in queue uinodes #17668

wants to merge 2 commits into from
+24 −15

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Feb 3, 2025 •
edited
Loading

Objective

queue_uinodes looks up the ExtractedView for every extracted UI node, but there's no need to look it up again if consecutive nodes have the same extracted_camera_entity.

Solution

In queue uinodes reuse the previously looked up extracted view if the extracted_camera_entity doesn't change

Showcase

cargo run --example many_buttons --release --features "trace_tracy"
queue-ui-improvement

yellow is this PR, red is main

@ickshonpe ickshonpe force-pushed the queue-uinodes-retain-camera branch from eea9169 to 47bdab7 Compare February 3, 2025 23:23
@ickshonpe ickshonpe added A-UI Graphical user interfaces, styles, layouts, and widgets C-Performance A change motivated by improving speed, memory usage or compile times S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Performance A change motivated by improving speed, memory usage or compile times S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ickshonpe