added an example showing how to use with_rect #17664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
alice-i-cecile
added
A-Rendering
alice-i-cecile
requested changes
Feb 3, 2025
There was a problem hiding this comment.
I like this, but IMO this sort of documentation on "how to use a specific API" is best suited to API docs. Examples are harder to discover and much more expensive to maintain.
Can you condense this and move it over to a doc test (and maybe some extra explanation there?).
alice-i-cecile
added
the
S-Waiting-on-Author
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
Co-authored-by: Alice Cecile <[email protected]>
|
Thanks! |
alice-i-cecile
approved these changes
Feb 5, 2025
|
@Carter0, I'd appreciate your review here if you have a minute :) |
alice-i-cecile
added
D-Straightforward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add an example demonstrating the use of
ImageNode::rectFixes #16482
Solution
Modified the code in the original issue #16457
Testing
to test run
cargo run --example image_rect --release