Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Benchmark overhead of validation for:
DynSystemParam
,ParamSet
,Needed for #15606
Solution
As noted in objective, I've added 3 benchmarks, where each uses an excessive amount of the specific functionality.
I benchmark on the level of schedules, rather than individual
validate_param
calls, so we get a better idea how changes to the code impact memory-lookup, etc. related side effects.Testing
2 back-to-back runs of the benchmarks, there is quire a lot of noise, can use feedback on fixing that