Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spirv_shader_passthrough must enable wgpu/spirv #15873

Merged
merged 2 commits into from
Oct 13, 2024
Merged

spirv_shader_passthrough must enable wgpu/spirv #15873

merged 2 commits into from
Oct 13, 2024
+1 −1

Conversation

BenjaminBrienen
Copy link
Contributor

Objective

Fixes #15515

Solution

I went for the simplest solution because "format" in shader_format_spirv didn't sound directly related.

Testing

The command cargo b -p bevy --no-default-features -F spirv_shader_passthrough,x11 failed before, but works now.

@BenjaminBrienen BenjaminBrienen added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Reflection Runtime information about types S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 12, 2024
@BenjaminBrienen BenjaminBrienen added this to the 0.15 milestone Oct 12, 2024
@IQuick143 IQuick143 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 12, 2024
@BenjaminBrienen BenjaminBrienen self-assigned this Oct 12, 2024
BD103
BD103 approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :D

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 13, 2024
Merged via the queue into bevyengine:main with commit 37501e1 Oct 13, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tychedelia tychedelia tychedelia approved these changes

@JMS55 JMS55 JMS55 approved these changes

@BD103 BD103 BD103 approved these changes

Assignees

@BenjaminBrienen BenjaminBrienen

Labels
A-Reflection Runtime information about types C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.

spirv_shader_passthrough must enable wgpu/spirv
6 participants
@BenjaminBrienen @tychedelia @JMS55 @BD103 @alice-i-cecile @IQuick143