Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some animation doc improvements #15860

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

mweatherley
Copy link
Contributor

@mweatherley mweatherley commented Oct 11, 2024

Objective

Animation docs could use some clarification regarding:

  • how exactly curves are evaluated
  • how additive blend nodes actually work

Solution

Add some documentation that explains how curve domains are used and how additive blend nodes treat their children.

Commentary

The way additive blend nodes work right now is a little bit weird, since their first child's weight is ignored. Arguably this makes sense, since additive animations are authored differently from ordinary animations, but it also feels a bit strange. We could make the first node's weight actually be applied, and the present behavior would be recovered when the weight is set to 1.

The main disadvantage of how things are set up now is that combining a bunch of additive animations without a base pose is pretty awkward (e.g. to add them onto a base pose later in the graph). If we changed it, the main downside would be that reusing the same animation on different parts of the graph is harder; on the other hand, the weights can be locally reassigned by using blend nodes with no other children, which rectifies this shortfall.

@mweatherley mweatherley added C-Docs An addition or correction to our documentation A-Animation Make things move and change over time X-Uncontroversial This work is generally agreed upon D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 11, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 11, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 11, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 11, 2024
Merged via the queue into bevyengine:main with commit 81b3946 Oct 11, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Animation Make things move and change over time C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants