-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split up TextStyle
#15857
Merged
Merged
split up TextStyle
#15857
Changes from all commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
a6d1ac9
split up textstyle
ickshonpe f225ee8
Merge branch 'main' into text-style-split
ickshonpe 300d378
update text_access
ickshonpe 222efd3
updated some example
ickshonpe 86cd1cb
Added `TextColor` to bevy_text prelude
ickshonpe b89d4fc
Updated `text` example
ickshonpe 3a97382
updated examples
ickshonpe 4c4bf5c
updated more examples
ickshonpe 8858bac
updated more examples
ickshonpe 662071f
updated `virtual_time` example
ickshonpe ebfe991
updated text_access, added color accessors
ickshonpe 2356f9a
more examples
ickshonpe 38f4ff3
update example
ickshonpe 29a5627
updated example
ickshonpe 41aa6c2
added `get_color` to `TextReader`
ickshonpe a26024f
Added BLACK and WHITE consts to TextColor
ickshonpe 47bebed
added docstrings to new consts
ickshonpe ecce0e8
updated more examples
ickshonpe 81c22e9
more examples
ickshonpe af8805a
Derived Copy, Deref and DerefMut for TextColor
ickshonpe 0c3a03b
Updated fps_overlay
ickshonpe 7159d6b
more examples
ickshonpe fd6b7b9
more examples
ickshonpe f453fcf
Require `TextColor` for `TextSpan`
ickshonpe 5963080
example
ickshonpe 0537233
fix fps_overlay color updates
ickshonpe e51cf65
fix fps_overlay again
ickshonpe d474caf
Updated more examples
ickshonpe 4b75e38
more examples
ickshonpe fd2b81d
more examples
ickshonpe 7b4474f
another example
ickshonpe 985d208
example
ickshonpe c13dc88
more examples
ickshonpe 26ed300
another example
ickshonpe 26a8142
updated remaining UI examples
ickshonpe 917f9a5
Migrated remaining examples
ickshonpe 40ea18a
renamed `style` on `TextReader` to `font`, added `color` method
ickshonpe 4880eb8
Fixed doc comment links
ickshonpe 3369175
Fixed another doc comment link
ickshonpe 791986d
Fixed more comments
ickshonpe 385ced5
Removed trailing whitespaces
ickshonpe 282b400
Fixed some more comments
ickshonpe b78acd1
Removed unneeded conversion
ickshonpe 590ee96
Replaced missing text color in easing_functions example.
ickshonpe 4dbaf9b
fixed text colors in bevymark example
ickshonpe 0f2a4cd
fixed `TextSpan` doc example`
ickshonpe c14e50d
fixed doctests
ickshonpe d3d35f2
Merge branch 'text-style-split' of https://github.com/ickshonpe/bevy …
ickshonpe a39e416
Fixes for doc tests
ickshonpe 13b1846
Merge branch 'main' into text-style-split
ickshonpe 8c77e36
Fixed widget/text module's doc test
ickshonpe 37fc79f
add a From Into<Color> for TextColor impl
ickshonpe 5c0d007
Fixed namings in `pipeline`
ickshonpe da84131
another renaming
ickshonpe 4796821
More renamings
ickshonpe bda4be2
More renamings
ickshonpe 270b640
Merge branch 'main' into text-style-split
ickshonpe 868b270
renaming to fit new api
ickshonpe bc9ae9a
More renamings
ickshonpe 0833e1e
Removed `text_style` variable from example.
ickshonpe 07da055
update example variable names
ickshonpe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep
for_each_style
and have it pass both the font and color as params?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could but I'm wondering if all these helper functions are even needed though. Users can just use
for_each
and ignore the fields that they don't need? We could return a struct with named fields instread of an optional tuple to make it more ergonomic.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I believe that we should leave this helpers to a follow-up PR so we can discuss better what to do with them