Fix minimising example minimizing every frame
#15850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparrett
force-pushed
the
minimising-once
branch
from
ce5ce3e
to
5cbfa8c
Compare
mockersf
reviewed
Oct 11, 2024
Co-authored-by: François Mockers <[email protected]>
tim-blackbird
approved these changes
Oct 11, 2024
tim-blackbird
added
D-Trivial
mockersf
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The
minimisingexample is a bit annoying to run locally, because it attempts to minimize the window every frame, so un-minimizing it is difficult.Solution
Only minimize once.
The contents of the example can now be inspected, and the window easily closed after the minimization happens.
Testing
cargo run --example minimisingI tested on macos only.