-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Taffy 0.6 #15844
base: main
Are you sure you want to change the base?
Upgrade to Taffy 0.6 #15844
Conversation
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good besides the comments nits.
Adding the computed margin values would let me add support for margin-box
to #15561.
Nits addressed |
Objective
Taffy 0.6 doesn't include a huge amount relevant to Bevy. But it does:
box_sizing
stylemargin
in layoutStyle
struct, which opens up the possibility of using Bevy'sStyle
struct directly (although Bevy currently does some style resolution at conversion time which would no longer be cached if it was used directly).Solution
0.6.0
Testing
grid
example. All looks good.Breaking changes
The only "breaking" change is adding a field to
Style
. Probably doesn't bear mentioning?