Deprecate SpatialBundle

[NiseVoid]

Objective

• Required components replace bundles, but SpatialBundle is yet to be deprecated

Solution

• Deprecate SpatialBundle
• Insert Transform and Visibility instead in examples using it
• In spawn or insert inserting a default Transform or Visibility with component already requiring either, remove those components from the tuple

Testing

• Did you test these changes? If so, how?
  Yes, I ran the examples I changed and tests
• Are there any parts that need more testing?
  The gamepad_viewer and and custom_shader_instancing examples don't work as intended due to entirely unrelated code, didn't check main.
• How can other people (reviewers) test your changes? Is there anything specific they need to know?
  Run examples, or just check that all spawned values are identical
• If relevant, what platforms did you test these changes on, and are there any important ones you can't test?
  Linux, wayland trough x11 (cause that's the default feature)

---

Migration Guide

SpatialBundle is now deprecated, insert Transform and Visibility instead which will automatically insert all other components that were in the bundle. If you do not specify these values and any other components in your spawn/insert call already requires either of these components you can leave that one out.

before:

commands.spawn(SpatialBundle::default());

after:

commands.spawn((Transform::default(), Visibility::default());

[alice-i-cecile]

The gamepad_viewer and and custom_shader_instancing examples don't work as intended due to entirely unrelated code, didn't check main.

Can you check the issues for these? I think the former is not yet reported.

[mnmaita]

Shouldn't Visibility::default() be added on these removals too?

[NiseVoid]

The bounding example actually doesn't use visibility at all (nor GlobalTransform), I created this example but I'm not sure why I used SpatialBundle instead of just Transform.

[mnmaita]

This should also have Visibility::Visible right? I assume FogVolume would be requiring Visibility::default() if not. It might not matter though...

[NiseVoid]

Same as above, in this case FogVolume requires Visibility which means it defaults to Inherited, and functions as visible.

[mnmaita]

Thanks for addressing my comments!

[tom-frantz]

Looks good to me! @mnmaita 's comments look like they were all covered, and the other examples had the necessary required components. I didn't see any other uses of SpatialBundle throughout the code base either, so I'm happy to approve given alice-i-cecile 's comments are covered too!