Add window drag move and drag resize without decoration example. #15814
+167
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Examples
|
@IsseW can I get your review here? |
alice-i-cecile
added
D-Straightforward
I can review tomorrow! |
|
Re: unsafe I've submitted a PR to winit so it may not panic in the future when a left-click event isn't present, which I'd then be satisfied without any unsafe markers on the functions. |
IsseW
approved these changes
Oct 11, 2024
Cargo.toml
Outdated
| @@ -2934,6 +2934,7 @@ name = "window_fallthrough" | |||
| path = "examples/ui/window_fallthrough.rs" | |||
| doc-scrape-examples = true | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Yes, that was a mistake. Will fix.
| @@ -379,7 +379,7 @@ impl Window { | |||
| /// | |||
| /// There is no guarantee that this will work unless the left mouse button was | |||
| /// pressed immediately before this function was called. | |||
| pub fn start_drag_resize(&mut self, direction: ResizeDirection) { | |||
| pub fn start_drag_resize(&mut self, direction: CompassOctant) { | |||
There was a problem hiding this comment.
I like this idea of using the existing CompassOctant 😄
MiniaczQ
approved these changes
Oct 13, 2024
| } | ||
| } | ||
|
|
||
| fn move_windows( |
There was a problem hiding this comment.
Suggested change
| fn move_windows( | |
| fn move_or_resize_window( |
| for mut window in windows.iter_mut() { | ||
| match *action { | ||
| LeftClickAction::Nothing => (), | ||
| LeftClickAction::Drag => window.start_drag_move(), |
There was a problem hiding this comment.
Suggested change
| LeftClickAction::Drag => window.start_drag_move(), | |
| LeftClickAction::Move => window.start_drag_move(), |
this would be more consistent with drag_move vs drag_resize
BenjaminBrienen
approved these changes
Oct 13, 2024
| //! | ||
| //! When window decorations are not present, the user cannot drag the window. | ||
| //! The `start_drag_move()` function will permit the application to make the | ||
| //! window draggable. It does require that the left mouse button was pressed |
There was a problem hiding this comment.
is being pressed sounds better to me. Currently the tenses are conflicting.
| //! When window decorations are not present, the user cannot drag the window. | ||
| //! The `start_drag_move()` function will permit the application to make the | ||
| //! window draggable. It does require that the left mouse button was pressed | ||
| //! when it is called. |
There was a problem hiding this comment.
When (inconsistent capitalization with other comments)
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add an example for the new drag move and drag resize introduced by PR #15674 and fix #15734.
Solution
I created an example that allows the user to exercise drag move and drag resize separately. The user can also choose what direction the resize works in.
Name
The example is called
window_drag_move. Happy to have that bikeshedded.Contentious Refactor?
This PR removed the
ResizeDirectionenumeration in favor of usingCompassOctantwhich had the same variants. Perhaps this is contentious.Unsafe?
In PR #15674 I mentioned that
start_drag_move()andstart_drag_resize()'s requirement to only be called in the presence of a left-click looks like a compiler-unenforceable contract that can cause intermittent panics when not observed, so perhaps the functions should be marked them unsafe. I have not made that change here since I didn't see a clear consensus on that.Testing
I exercised this on x86 macOS. However, winit for macOS does not support drag resize. It reports a good error when
start_drag_resize()is called. I'd like to see it tested on Windows and Linux.Showcase
Example window_drag_move shows how to drag or resize a window without decoration.