Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing cargo check with only the bevy_dev_tools feature #15743

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix failing cargo check with only the bevy_dev_tools feature #15743

merged 2 commits into from
Oct 8, 2024

Conversation

papow65
Copy link
Contributor

@papow65 papow65 commented Oct 8, 2024

Objective

Fixes #15741

Solution

  • Copied the feature gates of a type to where the type is used.

Testing

  • cargo check works now using only the bevy_dev_tools feature

@tim-blackbird tim-blackbird added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Gizmos Visual editor and debug gizmos labels Oct 8, 2024
tim-blackbird
tim-blackbird approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@tim-blackbird tim-blackbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Caused by me in #15713, sorry!

@tim-blackbird tim-blackbird added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 8, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 8, 2024
Merged via the queue into bevyengine:main with commit 01b37d6 Oct 8, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@pablo-lua pablo-lua pablo-lua approved these changes

Assignees
No one assigned
Labels
A-Gizmos Visual editor and debug gizmos C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo check fails with only the bevy_dev_tools feature
4 participants
@papow65 @tim-blackbird @pablo-lua @alice-i-cecile