Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Handle<AnimationGraph> component with a wrapper #15742

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Replace Handle<AnimationGraph> component with a wrapper #15742

merged 2 commits into from
Oct 8, 2024

Conversation

tim-blackbird
Copy link
Contributor

Objective

Solution

  • Wrap the handle in a new wrapper component: AnimationGraphHandle.

Testing

Searched for all instances of AnimationGraph in the examples and updated and tested those

Migration Guide

Handle<AnimationGraph> is no longer a component. Instead, use the AnimationGraphHandle component which contains a Handle<AnimationGraph>.

@tim-blackbird tim-blackbird added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Animation Make things move and change over time D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 8, 2024
@tim-blackbird tim-blackbird added this to the 0.15 milestone Oct 8, 2024
@tim-blackbird tim-blackbird added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Oct 8, 2024
mweatherley
mweatherley approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@mweatherley mweatherley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny nit

crates/bevy_animation/src/graph.rs Outdated Show resolved Hide resolved
@mweatherley mweatherley added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 8, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 8, 2024
Merged via the queue into bevyengine:main with commit 700123e Oct 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bushrat011899 bushrat011899 bushrat011899 approved these changes

@mweatherley mweatherley mweatherley approved these changes

@atornity atornity atornity approved these changes

Assignees
No one assigned
Labels
A-Animation Make things move and change over time C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.

Stop using Handle<AnimationGraph> as a component
5 participants
@tim-blackbird @bushrat011899 @mweatherley @atornity @alice-i-cecile