-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement From
translation and rotation for isometries
#15733
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jondolf
added
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
A-Math
Fundamental domain-agnostic mathematical operations
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
labels
Oct 8, 2024
Added to the 0.15 milestone since the existing isometry API without this could be considered a UX regression by some users. Feel free to remove though |
alice-i-cecile
approved these changes
Oct 8, 2024
tim-blackbird
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, with this I'd say the gizmo API has been improved over what it was before the move to isometry :)
tim-blackbird
added
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
and removed
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
labels
Oct 8, 2024
mweatherley
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Gizmos
Visual editor and debug gizmos
A-Math
Fundamental domain-agnostic mathematical operations
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Several of our APIs (namely gizmos and bounding) use isometries on current Bevy main. This is nicer than separate properties in a lot of cases, but users have still expressed usability concerns.
One problem is that in a lot of cases, you only care about e.g. translation, so you end up with this:
The isometry adds quite a lot of length and verbosity, and isn't really that relevant since only the translation is important here.
It would be nice if you could use the translation directly, and only supply an isometry if both translation and rotation are needed. This would make the following possible:
removing a lot of verbosity.
Solution
Implement
From<Vec2>
andFrom<Rot2>
forIsometry2d
, andFrom<Vec3>
,From<Vec3A>
, andFrom<Quat>
forIsometry3d
. These are lossless conversions that fit the semantics ofFrom
.This makes the proposed API possible! The methods must now simply take an
impl Into<IsometryNd>
, and this works: