Fixes to animation graph evaluation #15689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweatherley
added
C-Bug
mweatherley
added
the
S-Needs-Review
alice-i-cecile
approved these changes
Oct 7, 2024
alice-i-cecile
changed the title
|
Looks good, oops! |
pcwalton
approved these changes
Oct 7, 2024
mockersf
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix a couple of substantial errors found during the development of #15665:
AnimationCurveEvaluator::addwas secretly unreachable. In other words, additive blending never actually occurred.ActiveAnimation's weights were used.Solution
Made additive blending reachable and included the graph node weight in the weight of the stack elements appended in the curve application loop of
animate_targets.Testing
Tested on existing examples and on the new example added in #15665.