-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
# Objective Fixes #13479 This also fixes the gaps you can sometimes observe in outlines (screenshot from main, not this PR): <img width="636" alt="outline-gaps" src="https://github.com/user-attachments/assets/c11dae24-20f5-4aea-8ffc-1894ad2a2b79"> The outline around the last item in each section has vertical gaps. ## Solution Draw the outlines with corner radius using the existing border rendering for uinodes. The outline radius is very simple to calculate. We just take the computed border radius of the node, and if it's greater than zero, add it to the distance from the edge of the node to the outer edge of the node's outline. --- ## Showcase <img width="634" alt="outlines-radius" src="https://github.com/user-attachments/assets/1ecda26c-65c5-41ef-87e4-5d9171ddc3ae"> --------- Co-authored-by: Jan Hohenheim <[email protected]>
- Loading branch information
1 parent
82128d7
commit a0f5ea0
Showing
2 changed files
with
79 additions
and
131 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters