Fixes/zellic audit remediations vpmv2 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livingrockrises
requested review from
filmakarov,
ankurdubey521,
Aboudjem,
AmanRaj1608 and
tomarsachin2271
| return EntryPoint__factory.connect(epf.address, provider.getSigner()); | ||
| } | ||
|
|
||
| export async function getUserOpEvent(ep: EntryPoint) { |
There was a problem hiding this comment.
Should be moved to utils
ankurdubey521
approved these changes
Nov 20, 2023
Aboudjem
suggested changes
Nov 20, 2023
Comment on lines
293
to
294
| // const ev = await getUserOpEvent(entryPoint); | ||
| // expect(ev.args.success).to.be.true; |
There was a problem hiding this comment.
need to discuss this with @ankurdubey521
There was a problem hiding this comment.
done. pushed updated code
test/bundler-integration/token-paymaster/btpm-undeployed-wallet.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+430
to
+432
| // await expect( | ||
| // entryPoint.handleOps([userOp], await offchainSigner.getAddress()) | ||
| // ).to.be.reverted; |
There was a problem hiding this comment.
can be removed or uncommented
| { | ||
| sender: walletAddress, | ||
| verificationGasLimit: 200000, // for positive case 200k | ||
| // preVerificationGas: 55000, // min expected by bundler is 46k |
| offchainSigner = ethersSigner[1]; | ||
| depositorSigner = ethersSigner[2]; | ||
| feeCollector = ethersSigner[3]; | ||
| walletOwner = deployer; // ethersSigner[3]; |
AmanRaj1608
reviewed
Nov 28, 2023
| @@ -52,7 +52,7 @@ contract VerifyingSingletonPaymasterV2 is | |||
| sstore(verifyingSigner.slot, _verifyingSigner) | |||
| sstore(feeCollector.slot, _feeCollector) | |||
| } | |||
| unaccountedEPGasOverhead = 12000; | |||
| unaccountedEPGasOverhead = 24000; | |||
There was a problem hiding this comment.
how is this value being decided here
There was a problem hiding this comment.
AmanRaj1608
approved these changes
Nov 28, 2023
AmanRaj1608
approved these changes
Nov 28, 2023
Aboudjem
reviewed
Nov 28, 2023
Comment on lines
+263
to
+272
| // Review | ||
| // 10/11 actual gas used | ||
| /* const paymasterIdBalanceDiffWithoutPremium = paymasterIdBalanceDiff | ||
| .mul(BigNumber.from(10)) | ||
| .div(BigNumber.from(11)); | ||
|
|
||
| console.log( | ||
| "paymasterIdBalanceDiffWithoutPremium ", | ||
| paymasterIdBalanceDiffWithoutPremium.toString() | ||
| ); */ |
There was a problem hiding this comment.
I'd like to keep it if I need to present more accounting check in future.
Aboudjem
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue: # (issue number)
Change Type
Checklist
Additional Information
Branch Naming