Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes/zellic audit remediations vpmv2 #52

Merged
merged 8 commits into from
Nov 28, 2023
Merged

Fixes/zellic audit remediations vpmv2 #52

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5f4b2ed
bundler test for 3.1
livingrockrises Nov 16, 2023
6074b93
fix for 3.2
livingrockrises Nov 16, 2023
402a442
update the test to reflect exact error
livingrockrises Nov 19, 2023
c7dc1df
negative tests mentioned in threat model + bundler integration test
livingrockrises Nov 20, 2023
d543e79
refactor utils
livingrockrises Nov 20, 2023
d7c18ff
Merge branch 'develop' into fixes/zellic-audit-remediations-VPMV2
livingrockrises Nov 20, 2023
1f940bd
add accounting tests + update overhead while deploying
livingrockrises Nov 25, 2023
ebbe8ae
respond to PR comments
livingrockrises Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion contracts/verifying/VerifyingSingletonPaymasterV2.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ contract VerifyingSingletonPaymasterV2 is
sstore(verifyingSigner.slot, _verifyingSigner)
sstore(feeCollector.slot, _feeCollector)
}
unaccountedEPGasOverhead = 12000;
unaccountedEPGasOverhead = 24000;
Copy link
Collaborator

@AmanRaj1608 AmanRaj1608 Nov 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this value being decided here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

through these tests here

https://github.com/bcnmy/biconomy-paymasters/blob/fixes/zellic-audit-remediations-VPMV2/test/sponsorship-paymaster/biconomy-verifying-paymaster-v2-specs.ts#L260

fixedPriceMarkup = 1100000; // 10%
}

Expand Down Expand Up @@ -130,6 +130,7 @@ contract VerifyingSingletonPaymasterV2 is
*/
function setFixedPriceMarkup(uint32 _markup) external payable onlyOwner {
require(_markup <= PRICE_DENOMINATOR * 2, "Markup too high");
require(_markup >= PRICE_DENOMINATOR, "Markup too low"); // if allowed that would mean discounted
uint32 oldValue = fixedPriceMarkup;
fixedPriceMarkup = _markup;
emit FixedPriceMarkupChanged(oldValue, _markup);
Expand Down
Loading
Loading