Merge pull request #52 from bcnmy/fixes/zellic-audit-remediations-VPMV2

Fixes/zellic audit remediations vpmv2
bcnmy · Nov 28, 2023 · 1c5157c · 1c5157c
2 parents cca5a30 + ebbe8ae
commit 1c5157c
Show file tree

Hide file tree

Showing 12 changed files with 801 additions and 139 deletions.
diff --git a/contracts/verifying/VerifyingSingletonPaymasterV2.sol b/contracts/verifying/VerifyingSingletonPaymasterV2.sol
@@ -52,7 +52,7 @@ contract VerifyingSingletonPaymasterV2 is
             sstore(verifyingSigner.slot, _verifyingSigner)
             sstore(feeCollector.slot, _feeCollector)
         }
-        unaccountedEPGasOverhead = 12000;
+        unaccountedEPGasOverhead = 24000;
         fixedPriceMarkup = 1100000; // 10%
     }
 
@@ -130,6 +130,7 @@ contract VerifyingSingletonPaymasterV2 is
      */
     function setFixedPriceMarkup(uint32 _markup) external payable onlyOwner {
         require(_markup <= PRICE_DENOMINATOR * 2, "Markup too high");
+        require(_markup >= PRICE_DENOMINATOR, "Markup too low"); // if allowed that would mean discounted
         uint32 oldValue = fixedPriceMarkup;
         fixedPriceMarkup = _markup;
         emit FixedPriceMarkupChanged(oldValue, _markup);