Update DocC for rules_swift 2.1.0 #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
changed the title
luispadron
force-pushed
the
luis/update-docc-rules-for-swift-2
branch
3 times, most recently
from
6cc3eb9
to
5d6214f
Compare
luispadron
force-pushed
the
luis/update-to-rules_swift-2
branch
2 times, most recently
from
a8e21cd
to
f56bb01
Compare
luispadron
force-pushed
the
luis/update-to-rules_swift-2
branch
from
f56bb01
to
c1b44bf
Compare
brentleyjones
pushed a commit
that referenced
this pull request
Jul 9, 2024
luispadron
force-pushed
the
luis/update-docc-rules-for-swift-2
branch
2 times, most recently
from
be85b8d
to
4fb192e
Compare
Updates the DocC rules to support rules_swift 2.x which introduced breaking changes to how Swift symbol graphs are collected. This PR updates to use the new aspect to extract the symbol graphs. The public API remains unchanged.
luispadron
force-pushed
the
luis/update-docc-rules-for-swift-2
branch
3 times, most recently
from
7f26425
to
168a214
Compare
luispadron
changed the title
luispadron
requested review from
BalestraPatrick,
brentleyjones,
keith,
mattrobmattrob and
thii
as code owners
luispadron
force-pushed
the
luis/update-docc-rules-for-swift-2
branch
from
168a214
to
2f42112
Compare
luispadron
force-pushed
the
luis/update-docc-rules-for-swift-2
branch
from
2f42112
to
3b0c933
Compare
brentleyjones
approved these changes
Jul 9, 2024
luispadron
force-pushed
the
luis/update-docc-rules-for-swift-2
branch
2 times, most recently
from
7acadd3
to
ebffa7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the DocC rules to support rules_swift 2.x which introduced breaking changes to how Swift symbol graphs are collected.
This PR updates to use the new aspect to extract the symbol graphs. The public API remains unchanged.
Fixes #2445