TEST: integrating rules swift 2 prs #2490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r logic. PiperOrigin-RevId: 589151949 (cherry picked from commit 41d5bb7)
…pects all values to be statically allocated and resolved at compile time. This pulls all of the module names found from SwiftInfo when gathering the swiftconstfiles. This appears to work in the test targets set up, which do lean on the multiple module strategy. PiperOrigin-RevId: 589938532 (cherry picked from commit 5668eb4)
…e's app intents metadata processor tool allows for. PiperOrigin-RevId: 590322476 (cherry picked from commit 21b435b)
… Xcode 15.3 builds, based on the version string reported from the XcodeVersionConfig provider. PiperOrigin-RevId: 601786735 (cherry picked from commit ea240b8)
luispadron
force-pushed
the
luis/test-integrating-rules_swift-2-prs
branch
from
3c74588
to
6d28aa8
Compare
Updates the DocC rules to support rules_swift 2.x which introduced breaking changes to how Swift symbol graphs are collected. This PR updates to use the new aspect to extract the symbol graphs. The public API remains unchanged.
luispadron
force-pushed
the
luis/test-integrating-rules_swift-2-prs
branch
from
6d28aa8
to
fa7b6ff
Compare
Fixes the following failure:
```
fastbuild/bin/tools/bundletool/bundletool_test.runfiles/_main/tools/bundletool/bundletool_test.py", line 146, in _assert_zip_contains
self.assertEquals(
^^^^^^^^^^^^^^^^^
AttributeError: 'BundlerTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?
```
|
FYI, probably won't merge any of the PRs that you have listed here until this PR is overall green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing integrating the following PRs:
assertEqualinstead ofassertEquals#2493