-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: replace tier4_map_msgs with autoware_map_msgs for MapProjectorInfo #9392
feat!: replace tier4_map_msgs with autoware_map_msgs for MapProjectorInfo #9392
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
97917d0
to
b7e6fe5
Compare
…Info Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
5249ab6
to
efe7553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (component_interface_specs)
@mitsudome-r please fix cppcheck-differential |
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
map/autoware_map_projection_loader/src/map_projection_loader.cpp
Outdated
Show resolved
Hide resolved
map/autoware_map_projection_loader/src/map_projection_loader.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9392 +/- ##
==========================================
- Coverage 29.52% 29.51% -0.01%
==========================================
Files 1444 1445 +1
Lines 108518 108523 +5
Branches 41395 41399 +4
==========================================
- Hits 32035 32032 -3
- Misses 73361 73371 +10
+ Partials 3122 3120 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@mitsudome-r Please check carefully whether other repositories need to be modified. |
@YamatoAndo Thank you. |
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for autoware_carla_interface
.
…rojectorInfo (autowarefoundation#9392)" This reverts commit 282a01d.
Description
This pull request replace tier4_map_msgs with autoware_map_msgs for MapProjectorInfo message.
Related links
Parent Issue:
How was this PR tested?
Tested locally with planning simulator.
(Also tested internally in TIER IV: https://evaluation.ci.tier4.jp/evaluation/reports/13a50fac-d48a-5d70-bb2d-bc162b72dffe?project_id=prd_jt, https://evaluation.ci.tier4.jp/evaluation/reports/da3a38df-8607-57ea-a588-0a6e6ef212d2?project_id=prd_jt)
Notes for reviewers
None.
Interface changes
Topic changes
Modifications
/map/map_projector_info
tier4_map_msgs/MapProjectorInfo
/map/map_projector_info
autoware_map_msgs/MapProjectorInfo
Effects on system behavior
None.