Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: replace tier4_map_msgs with autoware_map_msgs for MapProjectorInfo #9392

Merged

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Nov 20, 2024

Description

This pull request replace tier4_map_msgs with autoware_map_msgs for MapProjectorInfo message.

Related links

Parent Issue:

How was this PR tested?

Tested locally with planning simulator.
(Also tested internally in TIER IV: https://evaluation.ci.tier4.jp/evaluation/reports/13a50fac-d48a-5d70-bb2d-bc162b72dffe?project_id=prd_jt, https://evaluation.ci.tier4.jp/evaluation/reports/da3a38df-8607-57ea-a588-0a6e6ef212d2?project_id=prd_jt)

Notes for reviewers

None.

Interface changes

Topic changes

Modifications

Version Topic Type Topic Name Message Type Description
Old Pub/Sub /map/map_projector_info tier4_map_msgs/MapProjectorInfo projection information for map frame
New Pub/Sub /map/map_projector_info autoware_map_msgs/MapProjectorInfo projection information for map frame

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) tag:require-cuda-build-and-test labels Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (component_interface_specs)

@YamatoAndo
Copy link
Contributor

@mitsudome-r please fix cppcheck-differential

@mitsudome-r mitsudome-r added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 28, 2024
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 29.51%. Comparing base (c332e7e) to head (a32c249).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ap_projection_loader/src/map_projection_loader.cpp 63.63% 3 Missing and 1 partial ⚠️
...c/lanelet2_map_loader/lanelet2_map_loader_node.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9392      +/-   ##
==========================================
- Coverage   29.52%   29.51%   -0.01%     
==========================================
  Files        1444     1445       +1     
  Lines      108518   108523       +5     
  Branches    41395    41399       +4     
==========================================
- Hits        32035    32032       -3     
- Misses      73361    73371      +10     
+ Partials     3122     3120       -2     
Flag Coverage Δ *Carryforward flag
differential 30.65% <70.58%> (?)
total 29.51% <ø> (-0.01%) ⬇️ Carriedforward from dc75936

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YamatoAndo
Copy link
Contributor

@mitsudome-r
Copy link
Member Author

@YamatoAndo Thank you.
I will create the PRs for other repositories as well. I will also update the sample map in the documentation to make sure that they are aligned.

@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label Dec 2, 2024
Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for autoware_carla_interface.

@mitsudome-r mitsudome-r merged commit 282a01d into autowarefoundation:main Dec 3, 2024
35 checks passed
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants