Extra checks in UI before deleting an account #10242
Conversation
|
@weizhouapache @DaanHoogland had to create a new PR due to issues with rebase. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10242 +/- ##
==========================================
Coverage 15.13% 15.14%
Complexity 11279 11279
==========================================
Files 5408 5409 +1
Lines 474007 473786 -221
Branches 57822 57813 -9
==========================================
- Hits 71746 71741 -5
+ Misses 394240 394025 -215
+ Partials 8021 8020 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
@blueorangutan package |
|
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12179 |
| <a-input | ||
| v-model:value="form.name" | ||
| :placeholder="$t('label.enter.account.name')" | ||
| style="width: auto"/> |
There was a problem hiding this comment.
We could set the input width to 100%, in order to fill all available space:
| style="width: auto"/> | |
| style="width: 100%"/> |
| api('deleteAccount', { | ||
| id: this.resource.id | ||
| }).then(response => { | ||
| this.$pollJob({ | ||
| jobId: response.deleteaccountresponse.jobid, | ||
| title: this.$t('label.action.delete.account'), | ||
| description: this.resource.id, | ||
| successMessage: `${this.$t('message.delete.account.success')} - ${this.resource.name}`, | ||
| errorMessage: `${this.$t('message.delete.account.failed')} - ${this.resource.name}`, | ||
| loadingMessage: `${this.$t('message.delete.account.processing')} - ${this.resource.name}`, | ||
| catchMessage: this.$t('error.fetching.async.job.result') | ||
| }) | ||
| this.closeModal() |
There was a problem hiding this comment.
After deleting an account, the UI does not redirect the user to another page. As a consequence of that, the following errors are rendered on screen:
It would be interesting to redirect the user to the accounts section
| @@ -225,11 +225,10 @@ export default { | |||
| message: 'message.delete.account', | |||
| dataView: true, | |||
| disabled: (record, store) => { | |||
| return record.id !== 'undefined' && store.userInfo.accountid === record.id | |||
There was a problem hiding this comment.
It would be interesting to find a way to indicate to the users that the delete button will only become enabled when the account is disabled.
One way of achieving this would be keep the DeleteAccount component always enabled. When accounts are not disabled, then the component could show a message explaining that the account needs first to be disabled in order to proceed with the deletion.
|
as there seems to be confusing/disagreement on how to implement this I am moving it to 4.19.3 provisionally. |
Description
This PR fixes #9480
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?