Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Delete Account" pop-up verbiage #9480

Open
adietrich-ussignal opened this issue Aug 2, 2024 · 3 comments · May be fixed by #10242
Open

Improve "Delete Account" pop-up verbiage #9480

adietrich-ussignal opened this issue Aug 2, 2024 · 3 comments · May be fixed by #10242

Comments

@adietrich-ussignal
Copy link

ISSUE TYPE
  • Improvement Request
COMPONENT NAME
UI
CLOUDSTACK VERSION
4.19.0.2
CONFIGURATION

N/A

OS / ENVIRONMENT

N/A

SUMMARY

When deleting an account, the only information provided at the pop-up window to delete an account is "Please confirm that you want to delete this Account." While the documentation is clear on what occurs when an account is deleted, I think providing some of the key aspects of what is removed or an additional prompt such as "Type the name of the account to delete it" would be valuable to avoid removing instances or snapshots unintentionally.

STEPS TO REPRODUCE
1. In the UI, navigate to Accounts
2. Select an Account. 
3. Select Delete Account.
4. Observe focused prompt.
EXPECTED RESULTS
Additional text in the pop-up similar to:
"Note: Removal of an Account destroys instances owned by this account." 
ACTUAL RESULTS
The output below is displayed. 
Screenshot 2024-08-02 at 11 57 58 AM
@abh1sar
Copy link
Collaborator

abh1sar commented Jan 20, 2025

Also being discussed here #10128

Suggested fix :

  1. Account has to be disabled first for it to be deleted (Disabling actually shuts down all the VMs).
  2. Improve the warning message to say that all VMs, volumes and data associated with the account will be deleted.
  3. Additional prompt to type the name of the account to confirm account deletion.

@weizhouapache
Copy link
Member

another option is similar as deleteproject

@Parameter(name = ApiConstants.CLEANUP, type = CommandType.BOOLEAN, since = "4.16.0", description = "true if all project resources have to be cleaned up, false otherwise")
private Boolean cleanup;

please bear in mind, if we change the default behavior, other 3rd-party projects (e.g. terraform) might be impacted.

@abh1sar
Copy link
Collaborator

abh1sar commented Jan 22, 2025

@weizhouapache
This is mostly UI change.
Only check added is that account should be disabled before deleting, which I think is similar to other infrastructure resources.
Please advice on #10232

@abh1sar abh1sar moved this from Dev In Progress to ready for Review in Apache CloudStack BugFest - Issues Jan 22, 2025
@abh1sar abh1sar linked a pull request Jan 22, 2025 that will close this issue
14 tasks
@DaanHoogland DaanHoogland linked a pull request Jan 23, 2025 that will close this issue
14 tasks
@DaanHoogland DaanHoogland modified the milestones: 4.21.0, 4.19.2 Jan 23, 2025
@DaanHoogland DaanHoogland modified the milestones: 4.19.2, 4.19.3 Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment