Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow delete account only once it is disabled. Extra checks in UI. #10232

Closed
wants to merge 8 commits into from

Conversation

abh1sar
Copy link
Collaborator

@abh1sar abh1sar commented Jan 22, 2025

Description

This PR Fixes #9480

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

DaanHoogland and others added 4 commits October 2, 2024 16:50
… than English (apache#9766)

* Fix updateTemplatePermission UI in non-english language

* Improve fix

---------

Co-authored-by: Lucas Martins <[email protected]>
@abh1sar abh1sar requested a review from weizhouapache January 22, 2025 04:53
@abh1sar abh1sar changed the title Delete account Allow delete account only once it is disabled. Extra checks in UI. Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.18%. Comparing base (c94d0ab) to head (06efd8b).
Report is 81 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10232      +/-   ##
============================================
+ Coverage     16.06%   16.18%   +0.11%     
- Complexity    12862    13046     +184     
============================================
  Files          5641     5646       +5     
  Lines        493791   494814    +1023     
  Branches      59858    59956      +98     
============================================
+ Hits          79318    80065     +747     
- Misses       405691   405916     +225     
- Partials       8782     8833      +51     
Flag Coverage Δ
uitests 4.01% <ø> (-0.01%) ⬇️
unittests 17.03% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abh1sar
Copy link
Collaborator Author

abh1sar commented Jan 22, 2025

@blueorangutan package

@blueorangutan
Copy link

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12159

@abh1sar
Copy link
Collaborator Author

abh1sar commented Jan 22, 2025

@blueorangutan ui

@blueorangutan
Copy link

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10232 (QA-JID-519)

@DaanHoogland
Copy link
Contributor

@abh1sar ,can you rebase on 4.19, please?

@abh1sar abh1sar closed this Jan 22, 2025
@DaanHoogland DaanHoogland deleted the delete-account branch January 23, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "Delete Account" pop-up verbiage
5 participants