Assumptions for equiv_* #5233
Draft
Assumptions for equiv_* #5233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on existing code for input cone and the `sat` handling of `-set-assumes`. Update `equiv_assume.ys` to use `-set-assumes` option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
Fix #5196.
Explain how this is achieved.
-set-assumesoption toequiv_simple.equiv_*passes (justequiv_induct?).Based on
-set-assumesoption fromsatpass (also because that is an option rather than default behavior).I initially wasn't convinced that the
$assumecells would work with FFs because of theseed_anext_seed_astuff going on, but I think actually the implementation I did of not checking through the FFs and instead only testing the inputs of the$assumeis fine. It probably could use some tidy up though since it is a bit of a mess just because of how it does the same thing for both the A and B input cones.If applicable, please suggest to reviewers how they can test the change.