Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions passes/hierarchy/hierarchy.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1066,6 +1066,17 @@ struct HierarchyPass : public Pass {
mod->attributes[ID::initial_top] = RTLIL::Const(1);
else
mod->attributes.erase(ID::initial_top);

std::vector<IdString> abstract_ids;
for (auto cell : top_mod->cells()) {
IdString abstract_id = "$abstract" + cell->type.str();
if (design->module(cell->type) == nullptr && design->module(abstract_id))
abstract_ids.push_back(abstract_id);
}
for (auto abstract_id : abstract_ids)
design->module(abstract_id)->derive(design, {});
for (auto abstract_id : abstract_ids)
design->remove(design->module(abstract_id));
}

bool did_something = true;
Expand Down
18 changes: 18 additions & 0 deletions tests/various/hierarchy_reassign_localparam.ys
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
read_verilog -defer <<EOT

module bb (...);
localparam A = "abc";
input a;
output b;
endmodule

module top (...);
input a;
output b;
bb #(.A("def")) my_bb (a, b);
endmodule

EOT

logger -expect error "does not have a parameter named 'A'" 1
hierarchy -check -top top
Loading