-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize the Title Bar #50378
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Just to clarify, this is mostly @jameskoster and @richtabor great work, I just copied over from Figma :) |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Want to connect some dots, we can potentially close #48481 in favor of this one, perhaps. |
This comment was marked as resolved.
This comment was marked as resolved.
If the whole bar triggers the command palette, I'm not sure that the "view link" should sit within. Might make more sense to keep it next to the "preview" button (and change that one to icon button). |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Based on the feedback, I went ahead and tentatively updated this issue with the latest decisions and added the dev tag. If anything pops up as problematic, let's revisit. |
Is there a reason for the exclusion of the cmd+k hint when editing a template? |
No, we can keep it. I'll update. |
Not to distract here, but it'd be good to start exploring how things behave if we move the primary button to the right of the ellipsis menu, or right before it but after everything else; how plugins would look, etc. |
Kicked off work here if anyone wants to contribute. |
For reference, I shared some updated mockups for the mobile behavior here, and depending on feedback I will update this issue. |
Hi there! This is exciting to see come to life as we have a flow in WooCommerce that could benefit from a similar solution. In the new block-based product editing experience, the product description will launch the visual editor, which could look and feel like a template part. Borrowing ideas from some of the explorations I saw, we could show the template part name (in our case: Product description) in the new Title Bar and let the user easily go back to the main editor/form without switching contexts. switch-part.mov |
edit: this was a regression, made a revert in #50937 to resolve the issue. |
What's pending here to wrap the issue? |
This would be a great addition. A question came up in the latest call for testing about how to view a page once you have made edits in the Site Editor, and it's currently a bit tricky. Any chance this enhancement could make it into 6.3? 🤞 |
Related #50369, #50260, #50218, #50217, #48641
Let's solidify the design and describe all the states in detail so that implementation can go smoothly. There are functions being introduced (#44461) that necessitate the title bar.
Site Editor
Post Editor
It's unclear if we need to bring the title bar to the post editor at the same time or it can be in stages, but it'd be good to design the aspects that are necessary for the post editor context. Particularly editing the title and the permalink.
Mockups
Main site editor title bar:
Scaling to mobile, and considering the top toolbar option across breakpoints:
It is likely useful to keep this component site-editor first in the near future, but here is a sketch that explores adding it to the post editor.
The text was updated successfully, but these errors were encountered: