-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action to "View Site" from the Site Editor sidebar #50405
Comments
I don't love the varying sizes between the Perhaps we could use a smaller variant of the A smaller icon would also work better in the context of the Title bar (#50378 (comment)), and the newer ViewLink component in the editor header: |
Woops, overlooked the |
I wonder if in the site view, the site title could work as a link? I'm mainly thinking ahead to other options sitting in the site hub. A "plus" to add content, for example, could potentially sit there. I would think in the near term we can probably do with a plus in the title area of a detail page, but I still have a feeling that eventually such a plus will be convenient there. I would agree we need a harmonized external link icon. I think we can potentially update the main icon directly, I don't think we need two variants. The only thing to be careful of there, is searching the codebase for any instances where we are using it at half size, I think that is done in help-text in a few instances. |
Sounds like a good idea to me, we can add the 'Visit site' tooltip to it as an extra prompt - let me know if you want me to just switch that PR to do that for now instead of the extra icon. |
Maybe so? Although it's unclear that clicking site icon in the hub will take you back to WP Admin, but clicking the site title will take you to the front-of-site. |
Mainly I would urge caution in adding items to the site hub, keep it as contextual as possible as long as possible. I might see a "plus" button there to add new content, such as posts or pages, and we probably don't want to end up with too many buttons. It's a tricky balance. |
Should I just close my PR for now while this is discussed further? |
It is not possible to view your site within the Site View of the Site Editor. You can only do so after navigating into the Canvas and selecting the "View" selector in the editor toolbar.
Let's explore adding a "View Site" action from the Site Hub perhaps, to enable people to quickly view their site in a new tab.
Proposal
The text was updated successfully, but these errors were encountered: