Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Template Name clickable to open details #28243

Closed
annezazu opened this issue Jan 15, 2021 · 4 comments
Closed

Make Template Name clickable to open details #28243

annezazu opened this issue Jan 15, 2021 · 4 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

When using the Site Editor experiment, to get to the template details, you have to click on a quite small down arrow in order to open the information. In slack this came up as being fairly confusing as one expected to be able to open template details by clicking on the template name.

Here's a gif of the current experience:

temp details

What is your proposed solution?

Allow the template name to be clickable to open up template details. A larger clickable area should also help with accessibility.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Full Site Editing labels Jan 15, 2021
@jameskoster
Copy link
Contributor

Iirc the a11y issue here is that using the template name as a button label was not adequately descriptive of what clicking the button would actually do.

So the root of the problem seems to be that this component was originally performing two irreconcilable tasks from the a11y point of view:

  1. Communicating which template is being edited
  2. Acting as a link to view details of said template

We could combine the chevron and template name into a single button if the label was something like "View template name details", but that is unnecessarily verbose for task 1 outlined above, and doesn't play nicely when template part names are displayed here too. Hence consensus was found around separating the element in to two parts – label and button. It is a compromise that I would love to find a solution for!

@OlaIola
Copy link

OlaIola commented Jan 11, 2022

I am agreeing with Anne, I am trying to click on the name and getting nothing. I think for most users it will be confusing and not very convenient. The button is only 24px in width and can be easily missed. Possibly there can be some compromise to make the whole area clickable and at the same time not make the template name itself a button.

@annezazu
Copy link
Contributor Author

annezazu commented Feb 7, 2022

Noting that this is still an issue in 5.9. In the Site Editor, it shows as the above. In the Template editor via the Post Editor though, it does allow the full name to be clickable as shown below:

template.hover.mov

@annezazu
Copy link
Contributor Author

annezazu commented Jul 4, 2023

This has since evolved immensely leading to the current experience in 6.3 with this title bar: #50378 Closing this out as a result.

@annezazu annezazu closed this as completed Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants