Update the document title in the site editor to open the command tool #50369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
mtias,
jameskoster,
jasmussen,
glendaviesnz and
ntsekouras
|
Fast work, nice bootstrap!
@jameskoster what are good next steps? |
|
Size Change: -1.51 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
May 5, 2023
ntsekouras
reviewed
May 5, 2023
There was a problem hiding this comment.
Thanks Riad, this looks good!
I was wondering if the removed info from that heading section is still considered valuable and if we plan on moving them to a different place of the UI or not.
Also one small nitpick is that the heading seems like a button but only part of it is. Should we have the icon inside the button?
The reason I chose to do this is because (as shown in the screenshot in the description) we do want to add other buttons within that piece of UI (like the preview icon on the right).
I've confirmed with designers that this is the direction we want to go and that the info/UI there might not be as necessary as it used to be. |
|
We need an issue to capture the full scope of the document title, #48641 can potentially serve that purpose. This PR is working well, a couple of minor requests:
We also need to nail down which commands to show as suggestions when opening the command center in this context. But I assume that would be something to tackle separately? |
We can't especially since I assume we want to use text-ellipsis. We would have been able to center it using position absolute for the left/right buttons but since we don't know the width of these buttons, we don't know how much space we can use for the title in the middle.
The icon in the designs is gray, I'm happy to update if there's consensus here though.
Specially, the most important part for me here, is the behavior we want for these contextual commands. What happens when I hit |
I noticed this right off as well. If you add
I think yes. And as soon as you start searching, the search results replace the standard contextual commands.
The user shouldn't have to understand what context they're in. The context provides the suggested commands rendered right off and prioritizes those same commands in search. Then we will need a way to bound commands to a specific context(s). I.e. "Toggle Fullscreen Mode" in Post Editor, but not anywhere else. |
|
Provided some feedback here re post type icon and ensuring this works with the content vs template changes |
This only works because we don't have anything on the left, but we know we can show the page title there which width is variable. This is why I chose not to solve this "virtually". |
youknowriad
force-pushed
the
update/document-title
branch
from
ca3fb41 to
f06af5c
Compare
|
Flaky tests detected in 5b74050. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5001270263
|
youknowriad
force-pushed
the
update/document-title
branch
from
f06af5c to
483b752
Compare
|
Copying over from the other, just a note that we need at least some treatment of how this works on mobile. Here's a sketch:'
|
We can in this PR of course, but when we'll introduce "back" buttons... we won't be anymore because we can't have buttons within buttons
Sure
Sure |
|
Pushed a couple of small style tweaks to match the original Figma. I set a fixed width on the shortcut for now, to ensure the document title is centrally aligned. We'll likely need to revisit that when we get to implementing the back button. There's still a layout issue on some screensizes: 
|
|
@jameskoster that should be fixed now. |
jameskoster
approved these changes
May 17, 2023
This was referenced May 18, 2023
youknowriad
force-pushed
the
update/document-title
branch
from
1e84e49 to
d6be278
Compare
|
Nice to see the red cleanup as well :) |
westonruter
added a commit
that referenced
this pull request
May 19, 2023
…dd/static-closures * 'trunk' of https://github.com/WordPress/gutenberg: (26 commits) Add transparent outline to input control BackdropUI focus style. (#50772) Added wrapper element for RichText in File block (#50607) Remove the experimental flag of the command center (#50781) Update the document title in the site editor to open the command center (#50369) Remove `unwrap` from transforms and add `ungroup` to more blocks (#50385) Add new experimental version of DropdownMenu (#49473) Force display of in custom css input boxes to LTR (#50768) Polish experimental navigation block (#50670) Support negation operator in selectors in the Interactivity API (#50732) Minor updates to theme.json schema pages (#50742) $revisions_controller is not used. Let's delete it. (#50763) Remove OffCanvasEditor (#50705) Mobile - E2E test - Update code to use the new navigateUp helper (#50736) Try: Smaller external link icon (#50728) Block Editor: Remove unused 'useIsDimensionsSupportValid' method (#50735) Fix flaky media inserter drag-and-dropping e2e test (#50740) docs: Fix change log typo (#50737) Edit Site: Fix `useEditedEntityRecord()` loading state (#50730) Fix labelling, description, and focus style of the block transform to pattern previews (#50577) Fix Global Styles sidebar block selection on zoom out mode (#50708) ...
Mamaduka
reviewed
May 23, 2023
packages/edit-site/src/components/header-edit-mode/document-actions/index.js
Show resolved
Hide resolved
kevin940726
reviewed
May 23, 2023
cbravobernal
changed the title
cbravobernal
changed the title
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Now that we have a command center, we need to improve its discoverability. The idea of this PR is to update the document title a little bit to be able to trigger the command center from there. It has been tossed around several times that this area should become something close to the url bar of the browser. This is kind of a step in that direction.
At the moment I've implemented the following changes:
The next steps will be:
Testing instructions