Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow the check for a NetworkObject component on NetworkBehaviours to be disabled #3031

Merged
merged 7 commits into from
Aug 31, 2024
Merged

fix: allow the check for a NetworkObject component on NetworkBehaviours to be disabled #3031

merged 7 commits into from
Aug 31, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Aug 25, 2024 •
edited
Loading

This PR adds an additional Multiplayer->Netcode for GameObjects property to control whether the in-editor NetworkBehaviour check for an associated NetworkObject is performed.
image

MTTB-373

fix: #2966

Changelog

  • Added: "Check for NetworkObject Component" property to the Multiplayer->Netcode for GameObjects project settings. When disabled, this will bypass the in-editor NetworkObject check on NetworkBehaviour components.

Testing and Documentation

  • No tests have been added.
  • Documentation changes will be determined. (wip)

@NoelStephensUnity
update
8706321 
Adding additional configuration parameter, NetworkBehaviour-Check-For-NetworkObject, that provides user the ability to bypass the automatic check for a NetworkObject on a NetworkBehaviour (in editor only).
@NoelStephensUnity
update
60baf87 
Adding project settings UI for the added check for networkobject property.
@NoelStephensUnity
update
b288ed5 
Exiting early if the check for NetworkObject setting is disabled.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review August 26, 2024 14:27
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner August 26, 2024 14:27
@NoelStephensUnity
update
fc33164 
change log entry
@NoelStephensUnity
update
bd2335d 
Disable and uncheck the Auto-Add NetworkObject Component when Check For NetworkObject Component is disabled.
Enable Auto-Add NetworkObject Component when Check For NetworkObject Component is re-enabled.
User can select if they want to re-check the Auto-Add NetworkObject Component at that point.
@NoelStephensUnity
Update CHANGELOG.md
76791b8
@NoelStephensUnity NoelStephensUnity mentioned this pull request Aug 26, 2024
Merged
@jabbacakes jabbacakes mentioned this pull request Aug 27, 2024
Merged
3 tasks
@jabbacakes
Copy link
Contributor

I think we maybe need a leetle doc update here, altho screenshots is probably overkill. See PR #1333 on the docs repo.

@NoelStephensUnity NoelStephensUnity merged commit 21cf55e into develop-2.0.0 Aug 31, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/allow-check-for-networkobject-to-be-disabled branch August 31, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelStephensUnity @jabbacakes