Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow the check for a NetworkObject component on NetworkBehaviours to be disabled (Back Port) #3034

Merged
merged 5 commits into from
Sep 3, 2024
Merged

fix: allow the check for a NetworkObject component on NetworkBehaviours to be disabled (Back Port) #3034

merged 5 commits into from
Sep 3, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

Backport of #3031.

This PR adds an additional Multiplayer->Netcode for GameObjects property to control whether the in-editor NetworkBehaviour check for an associated NetworkObject is performed.
image

MTTB-373

fix: #2966

Changelog

  • Added: "Check for NetworkObject Component" property to the Multiplayer->Netcode for GameObjects project settings. When disabled, this will bypass the in-editor NetworkObject check on NetworkBehaviour components.

Testing and Documentation

  • No tests have been added.
  • Documentation changes will be determined. (wip)

@NoelStephensUnity
update
0ddc938 
Add editor UI and additional NGO setting.
@NoelStephensUnity
update
77015f1 
Add check to see if we should perform the check for NetworkObject.
@NoelStephensUnity
update
ac02209 
Add the changelog entry
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review August 26, 2024 21:12
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner August 26, 2024 21:12
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) August 31, 2024 22:24
fluong6
fluong6 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@fluong6 fluong6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoelStephensUnity NoelStephensUnity merged commit 505261c into develop Sep 3, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/allow-check-for-networkobject-to-be-disabled-backport branch September 3, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluong6 fluong6 fluong6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permanently disable "Add NetworkObject Prompt" (Breaks Dynamically spawned Prefabs with nested Prefabs)
3 participants
@NoelStephensUnity @fluong6 @netcode-ci-service