-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Lb2pKg model #34
add Lb2pKg model #34
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice!
Seems that the model results in NaN values for now (?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IlyaSegal can you add *.html
to .gitignore
and remove this file?
Afaics, these files are generated in the source code folder (instead of _build/html
) if you use quarto render
(=pixi run doc
).
- no Graphs - up TBDsIO.jl, HadronicLineshapes.jl
I found the cause of the Inf: it was the normalization factors from #31 The BlattWeisskopf is currently defined as Now, the formfactors are replaced by the newly introduced |
The page should be built. The Dalitz looks reasonable, but the tests are not passed. |
Prefer to keep the finished analysis first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
Shall we aim to merge it today? AFAIR, the status is that the validation tests fail. Here is an input from the "true" model implementation, what we need to proceed here (open Lb2pKpi notebook, evaluate, report number here):
How does it sound @IlyaSegal |
After updating couplings, all validation points are yellow (difference in the third decimal digit). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, preview looks good now!
Adds Lb2pKg with json and qmd files,
Closes #6