Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lb2pkg #1

Closed
wants to merge 9 commits into from
Closed

Lb2pkg #1

wants to merge 9 commits into from

Conversation

IlyaSegal
Copy link
Collaborator

@IlyaSegal IlyaSegal commented Apr 27, 2024

I prepared a JSON file and a Julia test file for reading the LbpKg model.
For now, the test failed, throwing an error: ERROR: DomainError with -Inf.
Do you have any suggestions on what can be the reason?
Also, for now, I have excluded non-resonant poles since it is not possible to leave the "parametrization" field empty.
But, probably, I can try to add a function for the non-resonant poles (it is simply an exponent) based on the example of Breit-Wigner.
I inserted all the resonances with the L-S recoupling type. Am I right?
Am I missing something else, what can cause this divergence?

Closes #2

@mmikhasenko mmikhasenko changed the title Lb2p kg Lb2pkg Apr 28, 2024
@mmikhasenko
Copy link
Owner

mmikhasenko commented Apr 28, 2024

Also, for now, I have excluded non-resonant poles since it is not possible to leave the "parametrization" field empty.

For now, additional lineshapes are living in src/HadronicLineshapesIO.jl. E.g. you find there an implementation of BreitWignerWidthExp: one needs three blocks: structure, call, and a constructor of wrapper for parsing.

@mmikhasenko
Copy link
Owner

For now, the test failed, throwing an error: ERROR: DomainError with -Inf.
Do you have any suggestions on what can be the reason?

It was my issue, I've broken the test on Friday. Should be fixed now

@mmikhasenko
Copy link
Owner

I inserted all the resonances with the L-S recoupling type.

I think that is right.

@mmikhasenko
Copy link
Owner

well done!! 👍

  • test agains gitlab implementation
    the repository contains implementation of the model from scratch, no hs3.

It can be done by matching the value of the unpolarized_intensity for the build model against the reference in a single kinematic point.

A simple way to call unpolarized_intensity on a decay chain is unpolarized_intensity(model[3:3], sigma_test)

Copy link

codecov bot commented Apr 29, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@mmikhasenko
Copy link
Owner

@IlyaSegal have a look to minor updates of json file
8101c10
1d583a4

I've added validation step to tests. It passes now for Lc2ppiK, and fails for your decay.
The value for the cross check is made up. To put correct value, evaluate the notebook in
https://gitlab.cern.ch/mimikhas/Lb2pKg.jl
at the appropriate point

@mmikhasenko
Copy link
Owner

@mmikhasenko mmikhasenko closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lb2pKg implementation
2 participants