FEAT: define JSON schema for amplitude model format #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IlyaSegal maybe this schema is helpful for #6? |
redeboer
commented
May 13, 2024
redeboer
commented
May 13, 2024
|
So much fun. Copilot can take use of it, and write parts of the file. |
|
If the schema can validate #6, we can merge it. |
mmikhasenko
reviewed
May 13, 2024
mmikhasenko
requested changes
May 13, 2024
There was a problem hiding this comment.
Nice! Do you know if json schemas can be nested? - i has been discussed at HS3 for long time
Do you mean schema composition? It's essentially already happening through the |
redeboer
commented
May 14, 2024
|
good moment to merge? |
Just needs a PR approval ;) |
@mmikhasenko if you approve this PR, it should merge automatically |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
mmikhasenko
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defined a JSON schema based on the example
Lc2ppiK.jsonwhile understanding the format. The model is directly evaluated in VSCode — give it a try, by messing up some of the values and hovering over the keys to see their descriptions.Admittedly, JSON schema has less features than I thought. Particularly, I had hoped to build
enums for for instance the function names from the functions that are defined underfunctions. As far as I understand, that cannot be done dynamically with JSON schema. Still, there are some fancy things you can do, like validating whether spin definitions are valid.