Next/20221109/v9 #8165
Merged
Next/20221109/v9 #8165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various parts of ASAN will require creation of threads. At least LSAN reporting and ASAN stack traces require this. Detect if we run with ASAN and bypass the noproc setting with a warning. Bug: OISF#5661.
Ticket: OISF#5637
Signed-off-by: jason taylor <[email protected]>
Signed-off-by: jason taylor <[email protected]>
Signed-off-by: jason taylor <[email protected]>
Signed-off-by: jason taylor <[email protected]>
Signed-off-by: jason taylor <[email protected]>
Signed-off-by: jason taylor <[email protected]>
Signed-off-by: jason taylor <[email protected]>
Signed-off-by: jason taylor <[email protected]>
Signed-off-by: jason taylor <[email protected]>
Signed-off-by: jason taylor <[email protected]>
Signed-off-by: jason taylor <[email protected]>
Ticket: 2982 This commit validates that the content usage in a rule will not exceed the dsize value. Values of distance that cause the right edge to be exceeded are considered an error and the signature will be rejected.
This commit replaces a SCMalloc/memset with SCCalloc
This commit adds test cases that validate behavior when "content" immediately precedes "bsize".
This commit adds validation of the bsize value(s) with the available buffer size. Signatures are flagged if the bsize and buffer size are incompatible. Issue: 3682
This commit updates the bsize documentation 1. Describe what happens when "content" immediately precedes "bsize" 2. Include the operators and 3. Include examples using the operators.
This commit removes unused/commented out #include lines.
Issue: 2982 This commit moves bsize validation with respect to content matches to the post-parse validation stage. This allows bsize to consider all content-related values, including those that follow the bsize keyword.
victorjulien
requested review from
catenacyber and
jufajardini
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8165 +/- ##
==========================================
+ Coverage 81.68% 81.73% +0.04%
==========================================
Files 962 962
Lines 276851 276975 +124
==========================================
+ Hits 226146 226374 +228
+ Misses 50705 50601 -104
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 10592 |
This was referenced Nov 12, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
suricata-verify-pr: 1003