Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userguide: ip keyword updates v1 #8140

Closed

Conversation

jmtaylor90
Copy link
Contributor

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:

Describe changes:

  • update example rules to match rule style in other parts of the userguide
  • minor grammar updates

#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch:

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #8140 (7d8ae0e) into master (160c778) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8140   +/-   ##
=======================================
  Coverage   81.67%   81.67%           
=======================================
  Files         962      962           
  Lines      276781   276781           
=======================================
+ Hits       226052   226074   +22     
+ Misses      50729    50707   -22     
Flag Coverage Δ
fuzzcorpus 63.41% <ø> (+0.04%) ⬆️
suricata-verify 59.35% <ø> (-0.02%) ⬇️
unittests 63.35% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien mentioned this pull request Nov 12, 2022
@victorjulien
Copy link
Member

Merged in #8165, thanks!

@jmtaylor90 jmtaylor90 deleted the userguide-ip-keywords-updates-v1 branch November 21, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants