Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http uri spaces 2881 v12 #8134

Closed
wants to merge 2 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2881

Describe changes:

  • configures libhtp to allow spaces in URIs

Modifies #7915 with rebase

suricata-verify-pr: 837

OISF/suricata-verify#837

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #8134 (8f93e1b) into master (f251b6a) will increase coverage by 0.16%.
The diff coverage is 83.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8134      +/-   ##
==========================================
+ Coverage   81.51%   81.67%   +0.16%     
==========================================
  Files         962      962              
  Lines      276776   276799      +23     
==========================================
+ Hits       225620   226089     +469     
+ Misses      51156    50710     -446     
Flag Coverage Δ
fuzzcorpus 63.39% <83.33%> (+0.03%) ⬆️
suricata-verify 59.40% <77.77%> (+0.57%) ⬆️
unittests 63.35% <22.22%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

ERROR:
ERROR: Invalid Signature config error in ASAN_TLPR1_cfg QA test

ERROR: QA failed on ASAN_TLPR1_cfg.

Pipeline 10346

@victorjulien
Copy link
Member

Waiting for rule rebaseline in QA

@suricata-qa
Copy link

WARNING:

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

field baseline test %
SURI_TLPW1_stats_chk
.tcp.rst 128237 104031 81.12%
TREX_GENERIC_stats_chk
.capture.kernel_drops 0 1853775 -
.flow.end.state.new 6272 17625 281.01%
.flow.end.tcp_state.syn_sent 0 3665 -
.flow.end.tcp_state.syn_recv 0 48 -
.flow.end.tcp_state.established 53996 61081 113.12%
.flow.end.tcp_state.fin_wait1 0 450 -
.flow.end.tcp_state.fin_wait2 0 165 -
.flow.end.tcp_state.time_wait 0 237 -
.flow.end.tcp_state.last_ack 0 142 -
.flow.end.tcp_state.close_wait 0 620 -
.flow.end.tcp_liberal 80952 139414 172.22%
.tcp.reassembly_gap 80952 292536 361.37%
.tcp.overlap 0 22 -
.app_layer.error.http.parser 0 200 -
.app_layer.error.ftp.gap 0 34 -
.app_layer.error.smtp.gap 0 308 -
.app_layer.error.tls.gap 53852 104818 194.64%
.app_layer.error.dcerpc_tcp.parser 0 131 -
.ftp.memuse 0 128 -

Pipeline 10347

@ct0br0
Copy link

ct0br0 commented Nov 10, 2022

Looks like both of the runs (QA and manual) have the same increased alert count. Should be good, just will need to update QA baseline after merge.

@victorjulien victorjulien mentioned this pull request Nov 12, 2022
@victorjulien
Copy link
Member

Merged in #8165, thanks!

@catenacyber
Copy link
Contributor Author

Actually, this was not merged

@catenacyber catenacyber reopened this Nov 14, 2022
@victorjulien
Copy link
Member

Actually, this was not merged

Whoops, sorry about that. Looks like there was an issue with a pcap I shared privately. Forgot about it.

@catenacyber
Copy link
Contributor Author

Actually, this was not merged

Whoops, sorry about that. Looks like there was an issue with a pcap I shared privately. Forgot about it.

Indeed, it requires new OISF/libhtp#371

@catenacyber
Copy link
Contributor Author

Replaced by #8169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants