Http uri spaces 2881 v13 #8169
Closed
Http uri spaces 2881 v13 #8169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
requested review from
jufajardini and
victorjulien
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8169 +/- ##
==========================================
+ Coverage 81.73% 81.82% +0.09%
==========================================
Files 962 962
Lines 276975 277019 +44
==========================================
+ Hits 226379 226684 +305
+ Misses 50596 50335 -261
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING: ERROR: QA failed on SURI_TLPR1_alerts_cmp.
Pipeline 10607 |
jufajardini
reviewed
Dec 6, 2022
Comment on lines
+39
to
+42
| - Spaces are accepted in HTTP1 URIs instead of in the protocol version | ||
|
|
||
| That is `GET /a b HTTP/1.1` gets now URI as `a b` and protocol as `HTTP/1.1` when | ||
| it used to be URI as `a` and protocol as `b HTTP/1.1` |
There was a problem hiding this comment.
This part is a bit confusing... I think that two things could be done.
i) bring the next sentence together to the item list that starts this topic.
ii) adjust the text a bit.
Resulting in:
- Spaces are accepted in HTTP1 URIs instead of in the protocol version. That is:
`GET /a b HTTP/1.1` gets now URI as `a b` and protocol as `HTTP/1.1`. Before,
this would result in URI as `a` and protocol as `b HTTP/1.1`.
There was a problem hiding this comment.
uri would be /a b not a b (/ is part of the uri)
jufajardini
reviewed
Dec 6, 2022
|
Replaced by #8252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2881
Describe changes:
Modifies #8134 with rebase
libhtp-pr: 371
suricata-verify-pr: 1004
OISF/libhtp#371
OISF/suricata-verify#1004