transforms: remove dependency on C files #2143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting 8984bc68011, xor transform was moved to rust and this test was always skipped as it depended on the C file.
As most transforms have been moved to rust in suricata master
|
I wonder if we should have a more complete removal of these files checks... |
Yeah probably. Most of these were probably only mean to be temporary anywas.. A min-version with a minor version number is probably better. |
jasonish
approved these changes
Nov 27, 2024
victorjulien
approved these changes
Nov 28, 2024
Merged
|
Merged in #2156, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7229
#2137 + more fixes