Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect-xor: do not depend on C code #2137

Closed
wants to merge 1 commit into from

Conversation

inashivb
Copy link
Member

@catenacyber one of the exhibits of the problem you mentioned 🥲

Starting 8984bc68011, xor transform was moved to rust and this test was
always skipped as it depended on the C file.
@inashivb inashivb requested a review from catenacyber November 25, 2024 08:10
@inashivb inashivb added the tests pass These new tests should pass label Nov 25, 2024
@catenacyber
Copy link
Collaborator

Nice find, how did you find it ?

@inashivb
Copy link
Member Author

Nice find, how did you find it ?

Was just trying to reproduce the memleak issue you fixed w xor transform..

@catenacyber
Copy link
Collaborator

So, there are a lot more :

git grep '\- src/' | cut -d: -f2- | cut -d/ -f2- | sort | uniq -c
   4 detect-transform-casechange.c
   3 detect-transform-dotprefix.c
   1 detect-transform-xor.c

@catenacyber
Copy link
Collaborator

git grep '\- src/' | cut -d: -f2- | cut -d/ -f2- | sort | uniq | while read i; do echo -n $i; ls ../../suricata/src/$i; done | grep No full one-liner

@inashivb
Copy link
Member Author

Please consider PR #2143 instead of this. That one is more complete.

@inashivb inashivb closed this Nov 27, 2024
@inashivb inashivb deleted the minor-xor-test-fix/v1 branch November 27, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests pass These new tests should pass
Development

Successfully merging this pull request may close these issues.

3 participants