Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/84/20241202/v1 #2156

Merged
merged 2 commits into from
Dec 2, 2024
Merged

next/84/20241202/v1 #2156

merged 2 commits into from
Dec 2, 2024

Conversation

victorjulien
Copy link
Member

inashivb and others added 2 commits December 2, 2024 06:37
@inashivb @victorjulien
detect-xor: do not depend on C code
25ce7b0 
Starting 8984bc68011, xor transform was moved to rust and this test was
always skipped as it depended on the C file.
@catenacyber @victorjulien
transforms: remove dependency on C files
c5b3345 
As most transforms have been moved to rust in suricata master
catenacyber
catenacyber approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent with the only approved PR

@victorjulien victorjulien merged commit c5b3345 into OISF:master Dec 2, 2024
5 checks passed
@victorjulien victorjulien mentioned this pull request Dec 2, 2024
Closed
@victorjulien victorjulien deleted the next/84/20241202/v1 branch December 2, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber catenacyber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorjulien @catenacyber @inashivb