16.0 mig hr expense advance clearing #191

jumeldi74 · 2023-06-26T04:35:00Z

No description provided.

[UPD] Update hr_expense_advance_clearing.pot [UPD] README.rst

Fix install error when there are already some expense in system. [UPD] README.rst hr_expense_advance_clearing 12.0.1.0.1

We should prevent setting the analytic account in expenses used as employees advance. Otherwise, it can lead to errors charging against an analytic account that later won't be compensated when all is reconcile. Anyway, the advance is not an expense, but money of the company moving from one place to another, that later will be used for real expenses that will be imputed to the corresponding analytic account

…oduct

… view

… clearing

Saran440 · 2023-06-26T04:48:44Z

@jumeldi74 Thank you for your help migrate to v16
but expense in core odoo v16 has change big process.

version < 16, it will create journal entry when post journal entries at expense
version 16, it will create bills when post journal entries at expense

So, it must change code in this module for reconciled and matching.
We will migrate this module ASAP.

…t test)

jumeldi74 · 2023-06-26T05:05:10Z

@jumeldi74 Thank you for your help migrate to v16 but expense in core odoo v16 has change big process.

version < 16, it will create journal entry when post journal entries at expense version 16, it will create bills when post journal entries at expense

So, it must change code in this module for reconciled and matching. We will migrate this module ASAP.

Noted Sir. Thank you

…nit test)

…low 06072023

…earing process journal entries.

jumeldi74 · 2023-07-07T09:32:15Z

hi @Saran440 , allow me to try to migrate this module, need your review / feedback. We are planning to migrate and add other features in OCA env, this is the prelimenary effort, thanks

…earing advance journal entries.

LFPSGS · 2023-09-11T11:04:02Z

Hi @Saran440 and @jumeldi74

I wanted to thank you both for your efforts and ask if you could give any hints about a timeline to migrate this module to v16?

Best Regards,
Luiz Fernando

Saran440 · 2023-09-15T02:22:37Z

hr_expense_advance_clearing/models/hr_expense_sheet.py

+
+        # self = self.with_context(**clean_context(self.env.context))  # remove default_*
+        if self.advance_sheet_id and self.payment_mode == "own_account":
+            moves = res[self.id]


Suggested change

moves = res[self.id]

Saran440 · 2023-09-15T02:22:55Z

hr_expense_advance_clearing/models/hr_expense_sheet.py

+        # self = self.with_context(**clean_context(self.env.context))  # remove default_*
+        if self.advance_sheet_id and self.payment_mode == "own_account":
+            moves = res[self.id]
+            counter_line = moves.line_ids.filtered(


Suggested change

counter_line = moves.line_ids.filtered(

counter_line = res.line_ids.filtered(

Saran440 · 2023-09-15T02:37:18Z

@jumeldi74 Functional Test. I found bug

Create advance > submit > approve > post journal entries. state move to done it should move to state "Posted"
Create advance with "Clearing Product" > submit > approve > post journal entries > register payment > clear advance. it will error

RPC_ERROR
Odoo Server Error
Traceback (most recent call last):
  File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1584, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/opt/odoo/custom/src/odoo/odoo/service/model.py", line 133, in retrying
    result = func()
  File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1611, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1815, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "/opt/odoo/custom/src/odoo/odoo/addons/base/models/ir_http.py", line 154, in _dispatch
    result = endpoint(**request.params)
  File "/opt/odoo/custom/src/odoo/odoo/http.py", line 697, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/opt/odoo/auto/addons/web/controllers/dataset.py", line 42, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/opt/odoo/auto/addons/web/controllers/dataset.py", line 33, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/opt/odoo/custom/src/odoo/odoo/api.py", line 461, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "/opt/odoo/custom/src/odoo/odoo/api.py", line 448, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/opt/odoo/custom/src/odoo/odoo/models.py", line 6531, in onchange
    record._onchange_eval(name, field_onchange[name], result)
  File "/opt/odoo/custom/src/odoo/odoo/models.py", line 6242, in _onchange_eval
    method_res = method(self)
  File "/opt/odoo/auto/addons/hr_expense_advance_clearing/models/hr_expense_sheet.py", line 153, in _onchange_advance_sheet_id
    self.expense_line_ids += self.create_clearing_expense_line(line)
  File "/opt/odoo/auto/addons/hr_expense_advance_clearing/models/hr_expense_sheet.py", line 143, in create_clearing_expense_line
    clear_advance = self._prepare_clear_advance(line)
  File "/opt/odoo/auto/addons/hr_expense_advance_clearing/models/hr_expense_sheet.py", line 169, in _prepare_clear_advance
    clear_line._compute_from_product_id_company_id()  # Set some vals
AttributeError: 'hr.expense' object has no attribute '_compute_from_product_id_company_id'

The above server error caused the following client error:
null

case clearing > advance
Example.
Advance 100$, Clearing 130$
Clearing can post journal entries but can't register payment.

Saran440 · 2023-09-28T10:11:22Z

Move to #203

kittiu and others added 30 commits June 26, 2023 10:00

[12.0][ADD] hr_expense_advance_clearing

7b54880

[UPD] Update hr_expense_advance_clearing.pot [UPD] README.rst

[12.0][FIX] hr_expense_advance_clearing

96732b6

Fix install error when there are already some expense in system. [UPD] README.rst hr_expense_advance_clearing 12.0.1.0.1

[IMP] : black, isort

174ff72

[13.0][MIG] hr_expense_advance_clearing

b0022c1

[UPD] Update hr_expense_advance_clearing.pot

6688810

[UPD] README.rst

5a47fcc

[13.0][UPD] Add Contributors

14271cc

hr_expense_advance_clearing 13.0.1.0.1

3388235

[IMP] hr_expense_advance_clearing: hide analytics tags as well

5f1488b

hr_expense_advance_clearing 13.0.1.1.0

8707710

[FIX] rename fields residual

99c5950

[UPD] Update hr_expense_advance_clearing.pot

fd5665e

hr_expense_advance_clearing 13.0.1.2.0

318089e

[14.0][MIG] hr_expense_advance_clearing

ad303fa

[UPD] README.rst

bef2731

[FIX] hr_expense_advance_clearing: default_get return advance

6c2dd49

[UPD] Update hr_expense_advance_clearing.pot

d435256

hr_expense_advance_clearing 14.0.1.0.1

9938db0

[14.0][IMP] hr_expense_advance_clearing, add invisible fields

784deb0

hr_expense_advance_clearing 14.0.1.0.2

97954e6

[14.0][IMP] hr_expense_advance_clearing, allow predefined clearing pr…

a2148ef

…oduct

[UPD] Update hr_expense_advance_clearing.pot

27c92c8

[UPD] README.rst

7156109

hr_expense_advance_clearing 14.0.1.1.0

05774ea

[IMP] clearing tab on advance sheet

93d04ce

[UPD] Update hr_expense_advance_clearing.pot

c3e9f37

hr_expense_advance_clearing 14.0.1.2.0

28bc728

[14.0][IMP] hr_expense_advance_clearing, add invisible fields on tree…

b5f428f

… view

hr_expense_advance_clearing 14.0.1.2.1

cfcca23

Saran440 and others added 14 commits June 26, 2023 10:00

[FIX] test script - tax include price odoo/odoo@7cdaf33

83300c9

[FIX] payment return advance can related to advance

bff16a3

[UPD] Update hr_expense_advance_clearing.pot

b77b867

[UPD] README.rst

b1a2c48

[14.0][FIX] hr_expense_advance_clearing: allow general user to create…

4726daf

… clearing

hr_expense_advance_clearing 15.0.1.0.1

6a452b8

[15.0][FIX] hr_expense_advance_clearing: zero unit price

b871ea8

hr_expense_advance_clearing 15.0.1.1.0

72e2d57

[FIX] update readme

b625c90

[FIX] hr_expense_advance_clearing: change field not compute advance

a9cd35d

hr_expense_advance_clearing 15.0.1.2.0

a8c2d49

[UPD] README.rst

f63bb1f

[IMP] hr_expense_advance_clearing: pre-commit stuff

93e46f9

[MIG] hr_expense_advance_clearing: Migration to 16.0

f4a8c99

[MIG] hr_expense_advance_clearing: Migration to 16.0 (revision of uni…

5abeaf6

…t test)

jumeldi74 added 4 commits June 26, 2023 12:11

[MIG] hr_expense_advance_clearing: Migration to 16.0 (revision 2 of u…

2613783

…nit test)

[MIG] hr_expense_advance_clearing: Migration to 16.0 (revision 3 of u…

578add5

…nit test)

[MIG] hr_expense_advance_clearing: Migration to 16.0 - revision workf…

221558b

…low 06072023

[MIG] hr_expense_advance_clearing: Migration to 16.0 - revision 4: cl…

989a9ae

…earing process journal entries.

[MIG] hr_expense_advance_clearing: Migration to 16.0 - revision 5: cl…

77d3633

…earing advance journal entries.

em230418 mentioned this pull request Aug 1, 2023

[16.0][MIG] hr_expense_cancel: Migration to version 16.0 #187

Merged

Saran440 reviewed Sep 15, 2023

View reviewed changes

Saran440 mentioned this pull request Sep 18, 2023

[16.0][MIG] hr_expense_advance_clearing #203

Merged

1 task

Saran440 closed this Sep 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

16.0 mig hr expense advance clearing #191

16.0 mig hr expense advance clearing #191

jumeldi74 commented Jun 26, 2023

Saran440 commented Jun 26, 2023

jumeldi74 commented Jun 26, 2023

jumeldi74 commented Jul 7, 2023

LFPSGS commented Sep 11, 2023

Saran440 Sep 15, 2023

Saran440 Sep 15, 2023

Saran440 commented Sep 15, 2023

Saran440 commented Sep 28, 2023

	counter_line = moves.line_ids.filtered(
	counter_line = res.line_ids.filtered(

16.0 mig hr expense advance clearing #191

16.0 mig hr expense advance clearing #191

Conversation

jumeldi74 commented Jun 26, 2023

Saran440 commented Jun 26, 2023

jumeldi74 commented Jun 26, 2023

jumeldi74 commented Jul 7, 2023

LFPSGS commented Sep 11, 2023

Saran440 Sep 15, 2023

Choose a reason for hiding this comment

Saran440 Sep 15, 2023

Choose a reason for hiding this comment

Saran440 commented Sep 15, 2023

Saran440 commented Sep 28, 2023