Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] hr_expense_advance_clearing #203

Merged
merged 83 commits into from
Nov 29, 2023
Merged

[16.0][MIG] hr_expense_advance_clearing #203

merged 83 commits into from
Nov 29, 2023

Conversation

Saran440
Copy link
Member

@Saran440 Saran440 commented Sep 18, 2023 •
edited
Loading

This PR enhance code to support hr_expense in version 16

Depend on:

@Saran440
Copy link
Member Author

This PR from #191

@jumeldi74 @LFPSGS
It already to review. can you check please?

@Saran440 Saran440 mentioned this pull request Sep 18, 2023
Open
9 tasks
@Saran440 Saran440 force-pushed the 16.0-mig-hr_expense_advance_clearing_srl branch from d7cec04 to 7d38de0 Compare September 20, 2023 03:55
@Saran440 Saran440 mentioned this pull request Sep 28, 2023
Closed
@Saran440
Copy link
Member Author

Saran440 commented Oct 6, 2023

/ocabot migration hr_expense_advance_clearing

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 6, 2023
@Saran440 Saran440 mentioned this pull request Oct 6, 2023
Merged
2 tasks
rafaelbn
rafaelbn approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@rafaelbn
Copy link
Member

Ping @OCA/human-resources-maintainers

@Saran440 Saran440 force-pushed the 16.0-mig-hr_expense_advance_clearing_srl branch from 57fc212 to 7454475 Compare November 6, 2023 07:07
@gjlong68
Copy link

image

@ps-tubtim
Copy link
Member

Step to test

  1. Create Employee Advance with $ 400.00
    Selection_048

  2. Create Clearing with $ 720.00 (Clearing over Advance)
    Selection_049

I think the journal items of Clearing are incorrect, causing the journal items to be stuck, and waiting to be matched.

Selection_047
Selection_050

@Saran440
Copy link
Member Author

@ps-tubtim Thank you for your reviewed. I fixed it, Can you recheck please?

@gjlong68 I'm not sure what's wrong please explain step to error.

@gjlong68
Copy link

gjlong68 commented Nov 27, 2023 via email

ps-tubtim
ps-tubtim approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@ps-tubtim ps-tubtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test: Ok.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

kittiu and others added 12 commits November 29, 2023 15:36
@kittiu @Saran440
[12.0][ADD] hr_expense_advance_clearing
465173a 
[UPD] Update hr_expense_advance_clearing.pot

[UPD] README.rst
@kittiu @Saran440
[12.0][FIX] hr_expense_advance_clearing
eec406c 
Fix install error when there are already some expense in system.

[UPD] README.rst

hr_expense_advance_clearing 12.0.1.0.1
@kittiu @Saran440
[IMP] : black, isort
9cfe8ff
@kittiu @Saran440
[13.0][MIG] hr_expense_advance_clearing
a2f3d4c
@oca-travis @Saran440
[UPD] Update hr_expense_advance_clearing.pot
5d1ff88
@OCA-git-bot @Saran440
[UPD] README.rst
b8ba4af
@chienandalu @Saran440
[FIX] hr_expense_advance_clearing: analytic account visibility
1852637 
We should prevent setting the analytic account in expenses used as
employees advance. Otherwise, it can lead to errors charging against an
analytic account that later won't be compensated when all is reconcile.
Anyway, the advance is not an expense, but money of the company moving
from one place to another, that later will be used for real expenses
that will be imputed to the corresponding analytic account
@newtratip @Saran440
[13.0][UPD] Add Contributors
1884424
@OCA-git-bot @Saran440
hr_expense_advance_clearing 13.0.1.0.1
2d42591
@chienandalu @Saran440
[IMP] hr_expense_advance_clearing: hide analytics tags as well
945a636
@OCA-git-bot @Saran440
hr_expense_advance_clearing 13.0.1.1.0
6092bca
@Saran440
[FIX] rename fields residual
c28220b
kittiu and others added 22 commits November 29, 2023 15:36
@kittiu @Saran440
[IMP] hr_expense_advance_clearing: black, isort, prettier
f26126f
@kittiu @Saran440
[15.0][MIG] hr_expense_advance_clearing]
a0515a6
@kittiu @Saran440
[UPD] hr_expense_advance_clearing, use smart button instead of self o…
61abff6 
…ne2many
@kittiu @Saran440
[14.0][ENH] hr_expense_advance_clearing, not allow over return
4a46fa4
@Saran440
[FIX] do not allow cancel PV related clearing or return
8c2e9c5
@Saran440
[FIX] test script - tax include price odoo/odoo@7cdaf33
c36f0a1
@Saran440
[FIX] payment return advance can related to advance
677451d
@Saran440
[UPD] Update hr_expense_advance_clearing.pot
44f7388
@OCA-git-bot @Saran440
[UPD] README.rst
3ec5ed6
@ps-tubtim @Saran440
[14.0][FIX] hr_expense_advance_clearing: allow general user to create…
0f9ce00 
… clearing
@OCA-git-bot @Saran440
hr_expense_advance_clearing 15.0.1.0.1
47a64cc
@ps-tubtim @Saran440
[15.0][FIX] hr_expense_advance_clearing: zero unit price
5407016
@OCA-git-bot @Saran440
hr_expense_advance_clearing 15.0.1.1.0
87279c9
@Saran440
[FIX] update readme
0fc8aa3
@Saran440
[FIX] hr_expense_advance_clearing: change field not compute advance
50619f6
@OCA-git-bot @Saran440
hr_expense_advance_clearing 15.0.1.2.0
4dcd1f5
@OCA-git-bot @Saran440
[UPD] README.rst
59dedcf
@mymage @Saran440
Added translation using Weblate (Italian)
263dd50
@mymage @Saran440
Translated using Weblate (Italian)
bed5728 
Currently translated at 100.0% (57 of 57 strings)

Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_advance_clearing
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_advance_clearing/it/
@OCA-git-bot @Saran440
[UPD] README.rst
c9d12cf
@Saran440
[IMP] hr_expense_advance_clearing: pre-commit stuff
4550458
@Saran440
[MIG] hr_expense_advance_clearing: Migration to 16.0
e901f3a
@Saran440 Saran440 force-pushed the 16.0-mig-hr_expense_advance_clearing_srl branch from bacb865 to e901f3a Compare November 29, 2023 08:37
@Saran440
Copy link
Member Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-203-by-Saran440-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 31faf75 into OCA:16.0 Nov 29, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dd90ea8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps-tubtim ps-tubtim ps-tubtim approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
10 participants
@Saran440 @rafaelbn @gjlong68 @ps-tubtim @OCA-git-bot @kittiu @oca-travis @chienandalu @newtratip @mymage