[17.0][MIG] delivery_package_number: Migration to 17.0 #839

Josep-s73 · 2024-06-24T13:52:02Z

Standard migration to 17.0

hildickethan

code + functional

pedrobaeza · 2024-07-08T13:29:22Z

delivery_package_number/__manifest__.py

@@ -10,14 +10,13 @@
    "license": "AGPL-3",
    "installable": True,
    "application": False,
-    "depends": ["delivery"],
+    "depends": ["delivery", "stock_delivery"],


Why this new dependency?

it's a new glue module for pickings + delivery, the base delivery only handles the carrier models and adds shipping methods to sales now. Though the depends could be abbreviated to just ["stock_delivery"]

OK, I see. Maybe we should rename this to stock_delivery_package_number? cc @chienandalu @sergio-teruel

Odoo hasn't renamed any of their modules to stock_delivery_x so far, not even another glue module delivery_stock_picking_batch. I think it would more consistent to keep the current delivery_x naming

I'd keep it in the short form as well....

pedrobaeza · 2024-07-08T13:29:38Z

/ocabot migration delivery_package_number

chienandalu

There are pending forward ports in v16 as well: #788

ping @sergio-teruel

sergio-teruel · 2024-10-07T13:22:56Z

Hi @Josep-s73 , Can you add this commits from 16??

Thanks

[IMP] delivery_package_number: Make compatible with multi pickings validatio(aa27ae4)
[IMP] delivery_package_number: Ask only once for the number of packages wizard (5f3ca59)
[FIX] delivery_package_number: download label (1274e99)

[UPD] Update delivery_package_number.pot [UPD] README.rst

[UPD] Update delivery_package_number.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_package_number Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_package_number/

TT36946

…ransfer wizard if picking have not carrier. TT38549

TT40420

Fixes OCA#676

…zard

…delivery_carrier_label module

…nd new labels

chienandalu

There are still missing commits from v16. You can simply fetch a fresh v16 branch and redo the initial migration steps and then cherry pick your migration commit

chienandalu · 2024-11-27T08:16:52Z

delivery_package_number/views/stock_picking_views.xml

-                    name="number_of_packages"
-                    attrs="{'readonly': [('state', '=', 'done')]}"
-                />
+                <field name="number_of_packages" readonly="state ==  'done'" />


Suggested change

<field name="number_of_packages" readonly="state == 'done'" />

<field name="number_of_packages" readonly="state == 'done'" />

chienandalu · 2024-11-27T08:19:35Z

delivery_package_number/wizard/stock_backorder_confirmation_views.xml

@@ -7,19 +7,19 @@
        <field name="arch" type="xml">
            <xpath expr="//footer" position="before">
                <field name="ask_number_of_packages" invisible="1" />
-                <group attrs="{'invisible': [('ask_number_of_packages','=',False)]}">
+                <group invisible="ask_number_of_packages == False">


I like to rely on coercion of truthy / falsey values. I.e.: None is falsey but isn't equal to False. It's also more semantic

Suggested change

<group invisible="ask_number_of_packages == False">

<group invisible="not ask_number_of_packages">

chienandalu · 2024-11-27T08:20:38Z

delivery_package_number/wizard/stock_backorder_confirmation_views.xml

                    <field name="number_of_packages" />
                </group>
            </xpath>
            <xpath expr="//button[@special='cancel']" position="after">
                <field
                    name="print_package_label"
                    widget="boolean_toggle"
-                    attrs="{'invisible': [('ask_number_of_packages','=',False)]}"
+                    invisible="ask_number_of_packages == False"


Suggested change

invisible="ask_number_of_packages == False"

invisible="not ask_number_of_packages"

chienandalu · 2024-11-27T08:21:14Z

delivery_package_number/wizard/stock_backorder_confirmation_views.xml

                />
                <label
                    for="print_package_label"
-                    attrs="{'invisible': [('ask_number_of_packages','=',False)]}"
+                    invisible="ask_number_of_packages == False"


Suggested change

invisible="ask_number_of_packages == False"

invisible="not ask_number_of_packages"

chienandalu · 2024-11-27T08:22:17Z

delivery_package_number/__manifest__.py

@@ -10,14 +10,13 @@
    "license": "AGPL-3",
    "installable": True,
    "application": False,
-    "depends": ["delivery"],
+    "depends": ["delivery", "stock_delivery"],


Suggested change

"depends": ["delivery", "stock_delivery"],

"depends": ["stock_delivery"],

…lidation

…es wizard. TT48170

If we don't return the print action the label won't be downloaded. TT48759

chienandalu

Aside from the code remarks, the package number wizard isn't showing up correctly

chienandalu · 2024-11-28T08:35:44Z

delivery_package_number/wizard/stock_number_package_validate_wiz_view.xml

@@ -9,13 +9,13 @@
                <group>
                    <field
                        name="number_of_packages"
-                        attrs="{'invisible': [('stock_number_package_validation_line_ids', '!=', [])]}"
+                        invisible="stock_number_package_validation_line_ids != []"


This is why you should rely on python boolean coercion. This will allways be invisible with this condition

Suggested change

invisible="stock_number_package_validation_line_ids != []"

invisible="stock_number_package_validation_line_ids"

chienandalu · 2024-11-28T08:36:41Z

delivery_package_number/wizard/stock_number_package_validate_wiz_view.xml

-                        attrs="{'invisible': [('stock_number_package_validation_line_ids', '=', [])]}"
+                        invisible="stock_number_package_validation_line_ids == []"


The same goes for this one. This will never be invisible.

Suggested change

attrs="{'invisible': [('stock_number_package_validation_line_ids', '=', [])]}"

invisible="stock_number_package_validation_line_ids == []"

invisible="not stock_number_package_validation_line_ids"

chienandalu · 2024-11-28T08:38:11Z

delivery_package_number/README.rst

-<<<<<<< HEAD
-  * Pedro M. Baeza
-  * David Vidal
-  * Carlos Roca
-  * Sergio Teruel
+   -  Pedro M. Baeza
+   -  David Vidal
+   -  Marçal Isern
+   -  Carlos Roca


You should have resolve merge conflicts in the previous commit and don't let them show in the diff...

chienandalu · 2024-11-28T15:43:42Z

delivery_package_number/wizard/stock_number_package_validate_wiz_view.xml

+                <group>
+                    <field
+                        name="stock_number_package_validation_line_ids"
+                        invisible="not stock_number_package_validation_line_ids"
+                        nolabel="1"
+                    >
+                        <tree create="0" delete="0" editable="1">
+                            <field
+                                name="picking_id"
+                                options="{'no_open': True}"
+                                readonly="1"
+                                force_save="1"
+                            />
+                            <field name="number_of_packages" />
+                        </tree>
+                    </field>
+                </group>


To show the picking list correctly when validating package numbers in bulk

Suggested change

<group>

<field

name="stock_number_package_validation_line_ids"

invisible="not stock_number_package_validation_line_ids"

nolabel="1"

>

<tree create="0" delete="0" editable="1">

<field

name="picking_id"

options="{'no_open': True}"

readonly="1"

force_save="1"

/>

<field name="number_of_packages" />

</tree>

</field>

</group>

<field

name="stock_number_package_validation_line_ids"

invisible="not stock_number_package_validation_line_ids"

nolabel="1"

>

<tree create="0" delete="0" editable="1">

<field

name="picking_id"

options="{'no_open': True}"

readonly="1"

force_save="1"

/>

<field name="number_of_packages" />

</tree>

</field>

chienandalu

Thanks 👍

OCA-git-bot · 2024-11-29T10:28:17Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2024-11-29T11:41:24Z

/ocabot merge nobump

OCA-git-bot · 2024-11-29T11:41:31Z

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-839-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-11-29T11:46:37Z

Congratulations, your PR was merged at 9593b9d. Thanks a lot for contributing to OCA. ❤️

Josep-s73 force-pushed the 17.0-mig-delivery_package_number branch 2 times, most recently from 9f90731 to e4e66f4 Compare June 24, 2024 15:45

This was referenced Jun 26, 2024

[17.0][MIG] mig delivery_dhl_parcel OCA/l10n-spain#3646

Closed

[17.0][MIG] delivery_dhl_parcel: Migration to 17.0 OCA/l10n-spain#3648

Closed

pablo-marin-s73 mentioned this pull request Jul 2, 2024

[17.0][MIG] delivery_schenker #841

Open

arantxa-s73 mentioned this pull request Jul 5, 2024

[17.0][MIG] delivery_dhl_parcel: Migration to 17.0 OCA/l10n-spain#3658

Open

hildickethan approved these changes Jul 8, 2024

View reviewed changes

pedrobaeza reviewed Jul 8, 2024

View reviewed changes

OCA-git-bot added this to the 17.0 milestone Jul 8, 2024

OCA-git-bot mentioned this pull request Jul 8, 2024

Migration to version 17.0 #729

Open

27 tasks

chienandalu reviewed Jul 9, 2024

View reviewed changes

pablo-cort-s73 mentioned this pull request Nov 22, 2024

[17.0][MIG] delivery_correos_express: Migration to 17.0 #906

Open

chienandalu and others added 13 commits November 26, 2024 17:20

[ADD] delivery_package_number: New module

1bf7d28

Added translation using Weblate (Slovenian)

b79ac11

[IMP] delivery_package_number: black, isort, prettier

ced8dc8

[MIG] delivery_package_number: Migration to 13.0

2dade86

[UPD] Update delivery_package_number.pot [UPD] README.rst

[IMP] delivery_package_number: black, isort, prettier

8c305bb

[MIG] delivery_package_number: Migration to 15.0

0a78f20

TT36946

[IMP] delivery_package_number: Hide Number of packages in Immediate T…

e6b19e5

…ransfer wizard if picking have not carrier. TT38549

[MIG] delivery_package_number: Migration to 16.0

3a69644

TT40420

[FIX] delivery_package_number: Don't reset number on backorder

6634d02

Fixes OCA#676

[IMP] delivery_package_number: number of packages in the backorder wi…

ab961bf

…zard

[FIX] delivery_package_number: inhibit auto-create packets from base_…

af82d0a

…delivery_carrier_label module

[IMP] delivery_package_number: Allow set package numbers at confirm a…

7169bf2

…nd new labels

pablo-cort-s73 force-pushed the 17.0-mig-delivery_package_number branch 2 times, most recently from deaa126 to e37c6da Compare November 26, 2024 16:56

chienandalu suggested changes Nov 27, 2024

View reviewed changes

sergio-teruel and others added 3 commits November 27, 2024 10:47

[IMP] delivery_package_number: Make compatible with multi pickings va…

a070ef1

…lidation

[IMP] delivery_package_number: Ask only once for the number of packag…

3070a38

…es wizard. TT48170

[FIX] delivery_package_number: download label

83ebd80

If we don't return the print action the label won't be downloaded. TT48759

pablo-cort-s73 force-pushed the 17.0-mig-delivery_package_number branch 2 times, most recently from 9e8c795 to 563a0f8 Compare November 27, 2024 10:55

chienandalu suggested changes Nov 28, 2024

View reviewed changes

[IMP] delivery_package_number: pre-commit auto fixes

e1d0e55

pablo-cort-s73 force-pushed the 17.0-mig-delivery_package_number branch from 563a0f8 to d25bf60 Compare November 28, 2024 09:17

chienandalu reviewed Nov 28, 2024

View reviewed changes

[MIG] delivery_package_number: Migration to 17.0

db261ba

pablo-cort-s73 force-pushed the 17.0-mig-delivery_package_number branch from d25bf60 to db261ba Compare November 29, 2024 08:28

rousseldenis added needs review migration labels Nov 29, 2024

chienandalu approved these changes Nov 29, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Nov 29, 2024

OCA-git-bot added the bot is merging ⏳ label Nov 29, 2024

OCA-git-bot merged commit eef7866 into OCA:17.0 Nov 29, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] delivery_package_number: Migration to 17.0 #839

[17.0][MIG] delivery_package_number: Migration to 17.0 #839

Josep-s73 commented Jun 24, 2024

hildickethan left a comment

pedrobaeza Jul 8, 2024

hildickethan Jul 8, 2024

pedrobaeza Jul 8, 2024

hildickethan Jul 8, 2024

chienandalu Jul 9, 2024

pedrobaeza commented Jul 8, 2024

chienandalu left a comment

sergio-teruel commented Oct 7, 2024

chienandalu left a comment

chienandalu Nov 27, 2024

chienandalu Nov 27, 2024

chienandalu Nov 27, 2024

chienandalu Nov 27, 2024

chienandalu Nov 27, 2024

chienandalu left a comment

chienandalu Nov 28, 2024

chienandalu Nov 28, 2024

chienandalu Nov 28, 2024

chienandalu Nov 28, 2024

chienandalu left a comment

OCA-git-bot commented Nov 29, 2024

pedrobaeza commented Nov 29, 2024

OCA-git-bot commented Nov 29, 2024

OCA-git-bot commented Nov 29, 2024

	<field name="number_of_packages" readonly="state == 'done'" />
	<field name="number_of_packages" readonly="state == 'done'" />

	<group invisible="ask_number_of_packages == False">
	<group invisible="not ask_number_of_packages">

	invisible="ask_number_of_packages == False"
	invisible="not ask_number_of_packages"

	"depends": ["delivery", "stock_delivery"],
	"depends": ["stock_delivery"],

	invisible="stock_number_package_validation_line_ids != []"
	invisible="stock_number_package_validation_line_ids"

		attrs="{'invisible': [('stock_number_package_validation_line_ids', '=', [])]}"
		invisible="stock_number_package_validation_line_ids == []"

	attrs="{'invisible': [('stock_number_package_validation_line_ids', '=', [])]}"
	invisible="stock_number_package_validation_line_ids == []"
	invisible="not stock_number_package_validation_line_ids"

[17.0][MIG] delivery_package_number: Migration to 17.0 #839

[17.0][MIG] delivery_package_number: Migration to 17.0 #839

Conversation

Josep-s73 commented Jun 24, 2024

hildickethan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Jul 8, 2024

chienandalu left a comment

Choose a reason for hiding this comment

sergio-teruel commented Oct 7, 2024

chienandalu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Nov 29, 2024

pedrobaeza commented Nov 29, 2024

OCA-git-bot commented Nov 29, 2024

OCA-git-bot commented Nov 29, 2024