Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] delivery_dhl_parcel: Migration to 17.0 #3658

Open
wants to merge 22 commits into
base: 17.0
Choose a base branch
from

Conversation

arantxa-s73
Copy link

@arantxa-s73 arantxa-s73 commented Jul 3, 2024

Standard migration delivery_dhl_parcel

Depends on:

@pedrobaeza
Copy link
Member

Arantxa, evita por favor cerrar el PR cada vez que quieres hacer un cambio. Puedes simplemente empujar en la misma rama con git push -f para sobrescribir lo que haya. El título del PR tampoco es correcto. Cámbialo por favor.

@arantxa-s73 arantxa-s73 force-pushed the 17.0-mig-delivery_dhl_parcel branch from ff23e1f to 8bd0132 Compare July 5, 2024 10:49
@arantxa-s73 arantxa-s73 changed the title 17.0 mig delivery dhl parcel [17.0][MIG] delivery_dhl_parcel: Migration to 17.0 Jul 5, 2024
@hildickethan
Copy link
Member

hildickethan commented Jul 9, 2024

Haz cherry-pick de #3659 también, el módulo a nivel funcional es OK

Copy link

github-actions bot commented Dec 8, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 8, 2024
@ioans73
Copy link
Member

ioans73 commented Dec 9, 2024

@pedrobaeza Could you add "no stale" label please?

@pedrobaeza
Copy link
Member

Haced rebase quitando el commit de dependencia, ya que ahora está todo fusionado.

hildickethan and others added 20 commits December 9, 2024 08:09
[UPD] Update delivery_dhl_parcel.pot

[UPD] README.rst
delivery_dhl_parcel 14.0.1.1.0

[UPD] Update delivery_dhl_parcel.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-14.0/l10n-spain-14.0-delivery_dhl_parcel
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-delivery_dhl_parcel/
…l_last_response fields.

[UPD] Update delivery_dhl_parcel.pot

[UPD] README.rst

delivery_dhl_parcel 14.0.1.2.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-14.0/l10n-spain-14.0-delivery_dhl_parcel
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-delivery_dhl_parcel/
log_xml is a carrier function, self in this context is the DhlParcelRequest class

delivery_dhl_parcel 14.0.1.2.1
Currently translated at 2.1% (1 of 46 strings)

Translation: l10n-spain-14.0/l10n-spain-14.0-delivery_dhl_parcel
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-delivery_dhl_parcel/ca/
400 Client Error: Bad Request for url: https://external.dhl.es/cimapi/api/v1/customer/shipment
El peso del envío tiene que ser como mínimo 1 kilo o como máximo 99999 kilos

delivery_dhl_parcel 14.0.1.2.2
TT37163

[UPD] Update delivery_dhl_parcel.pot

[UPD] README.rst

delivery_dhl_parcel 14.0.1.3.0
…end day wizard.

TT37046

[UPD] Update delivery_dhl_parcel.pot

delivery_dhl_parcel 14.0.1.4.0
…errors at the end of the day.

TT37136

delivery_dhl_parcel 14.0.1.4.1
… the shipment.

TT37461

delivery_dhl_parcel 14.0.1.4.2

delivery_dhl_parcel 14.0.1.4.3
[UPD] README.rst

delivery_dhl_parcel 14.0.1.4.4
Create _prepare_dhl_parcel_parcel_address_info() function to reduce code.

Improve receiver + sender information:
- Remove blank spaces on partner phone
- Set phone or mobile from partner
- Concatenate street and street2 field
- Limit address field to 40 characters

TT40002

delivery_dhl_parcel 14.0.1.4.5
[UPD] Update delivery_dhl_parcel.pot

[UPD] README.rst

delivery_dhl_parcel 14.0.2.0.0

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-14.0/l10n-spain-14.0-delivery_dhl_parcel
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-delivery_dhl_parcel/
Currently translated at 100.0% (54 of 54 strings)

Translation: l10n-spain-14.0/l10n-spain-14.0-delivery_dhl_parcel
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-delivery_dhl_parcel/es/
@ioans73 ioans73 force-pushed the 17.0-mig-delivery_dhl_parcel branch from 367be81 to e0f1756 Compare December 9, 2024 07:09
@ioans73
Copy link
Member

ioans73 commented Dec 9, 2024

Haced rebase quitando el commit de dependencia, ya que ahora está todo fusionado.

Hecho!

@@ -169,6 +169,7 @@ def dhl_parcel_send_shipping(self, pickings):
result.append(vals)
continue
vals["tracking_number"] = response.get("Tracking", "")
vals["response"] = response
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esta nueva línea para qué es? No veo ningún campo con ese nombre.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es por este pr de la versión 14, #3508

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eso no se ha aprobado, y además, no se almacena en ningún sitio según veo. Quítalo por favor.

arantxa-s73 and others added 2 commits December 10, 2024 08:13
If we just show the partner's name there will be cases where we'll be
losing the most important info which is the main organization where the
shipping is sent.

TT49966
@arantxa-s73 arantxa-s73 force-pushed the 17.0-mig-delivery_dhl_parcel branch from e0f1756 to c3a4cb3 Compare December 10, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants